Attachment 346860 Details for Bug 188451 – Patch

[patch] Patch

bug-188451-20180809143200.patch (text/plain), 1.78 KB, created by Per Arne Vollan on 2018-08-09 14:32:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-08-09 14:32:01 PDT

Size: 1.78 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234734)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-09  Per Arne Vollan  <pvollan@apple.com>
>+
>+        [macOS] TestWebKitAPI should set user defaults for scrollbars.
>+        https://bugs.webkit.org/show_bug.cgi?id=188451
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
>+        user defaults related to scrollbars in the UI process as we do in the WebProcess.
>+
>+        * TestWebKitAPI/mac/mainMac.mm:
>+        (main):
>+
> 2018-08-09  Per Arne Vollan  <pvollan@apple.com>
> 
>         REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
>Index: Tools/TestWebKitAPI/mac/mainMac.mm
>===================================================================
>--- Tools/TestWebKitAPI/mac/mainMac.mm	(revision 234733)
>+++ Tools/TestWebKitAPI/mac/mainMac.mm	(working copy)
>@@ -40,8 +40,11 @@ int main(int argc, char** argv)
>         argumentDomain = [[NSMutableDictionary alloc] init];
>     
>     NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
>-                          [NSNumber numberWithBool:YES],    @"WebKitLinkedOnOrAfterEverything",
>-                          nil];
>+        [NSNumber numberWithBool:YES],    @"WebKitLinkedOnOrAfterEverything",
>+        [NSNumber numberWithBool:NO],     @"NSScrollAnimationEnabled",
>+        [NSNumber numberWithBool:NO],     @"NSOverlayScrollersEnabled",
>+        @"Always",                        @"AppleShowScrollBars",
>+        nil];
> 
>     [argumentDomain addEntriesFromDictionary:dict];
>     [[NSUserDefaults standardUserDefaults] setVolatileDomain:argumentDomain forName:NSArgumentDomain];

Actions: View | Formatted Diff | Diff

Attachments on bug 188451: 346860