Attachment 346850 Details for Bug 188389 – Patch

[patch] Patch

bug-188389-20180809112202.patch (text/plain), 1.63 KB, created by Sihui Liu on 2018-08-09 11:22:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-09 11:22:03 PDT

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 234686
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6d5d0624ccb43776c30b598021f2924e30391f1c..3091b48a48e07e3969a9e6c6d7f50640b320c9f3 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-08  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Avoid timeout resulted from calling waitUntilDone when test is not running
>+        https://bugs.webkit.org/show_bug.cgi?id=188389
>+
>+        If test is not running, we should not set the waitUntilDone flag, or it may cause subsequent tests timeout.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
>+        (WTR::TestRunner::waitUntilDone):
>+
> 2018-08-05  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] More tweaks and refactoring to prepare for ARC
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>index 27f0dd285b540ecff45825c63ee9dfd5972ce95a..3ed6074c2896122a09dc9fdcf59830509f375b94 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>@@ -185,9 +185,12 @@ void TestRunner::waitUntilDownloadFinished()
> 
> void TestRunner::waitUntilDone()
> {
>+    auto& injectedBundle = InjectedBundle::singleton();
>+    ASSERT(injectedBundle.isTestRunning());
>+
>     setWaitUntilDone(true);
>     // FIXME: Watchdog timer should be moved to UI process in order to take the elapsed time in anotehr process into account.
>-    if (InjectedBundle::singleton().useWaitToDumpWatchdogTimer())
>+    if (injectedBundle.useWaitToDumpWatchdogTimer())
>         initializeWaitToDumpWatchdogTimerIfNeeded();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188389: 346727 | 346750 | 346850 | 346854 | 346856 | 347039