Attachment 346801 Details for Bug 188370 – WIP

[patch] WIP

tmp.patch (text/plain), 2.34 KB, created by Ryosuke Niwa on 2018-08-08 14:54:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-08-08 14:54:09 PDT

Size: 2.34 KB

patch

obsolete

>Index: Source/WebCore/dom/Event.h
>===================================================================
>--- Source/WebCore/dom/Event.h	(revision 234680)
>+++ Source/WebCore/dom/Event.h	(working copy)
>@@ -119,6 +119,9 @@
>     bool defaultHandled() const { return m_defaultHandled; }
>     void setDefaultHandled() { m_defaultHandled = true; }
> 
>+    bool ignoreDefaultEventHandler() const { return m_ignoreDefaultEventHandler; }
>+    void setIgnoreDefaultEventHandler() { m_ignoreDefaultEventHandler = true; }
>+
>     void setInPassiveListener(bool value) { m_isExecutingPassiveEventListener = value; }
> 
>     bool cancelBubble() const { return propagationStopped(); }
>@@ -156,6 +159,7 @@
>     bool m_immediatePropagationStopped { false };
>     bool m_wasCanceled { false };
>     bool m_defaultHandled { false };
>+    bool m_ignoreDefaultEventHandler { false };
>     bool m_isTrusted { false };
>     bool m_isExecutingPassiveEventListener { false };
> 
>Index: Source/WebCore/dom/EventDispatcher.cpp
>===================================================================
>--- Source/WebCore/dom/EventDispatcher.cpp	(revision 234680)
>+++ Source/WebCore/dom/EventDispatcher.cpp	(working copy)
>@@ -167,7 +167,7 @@
>     // Call default event handlers. While the DOM does have a concept of preventing
>     // default handling, the detail of which handlers are called is an internal
>     // implementation detail and not part of the DOM.
>-    if (!event.defaultPrevented() && !event.defaultHandled()) {
>+    if (!event.defaultPrevented() && !event.defaultHandled() && !event.ignoreDefaultEventHandler()) {
>         // FIXME: Not clear why we need to reset the target for the default event handlers.
>         // We should research this, and remove this code if possible.
>         auto* finalTarget = event.target();
>Index: Source/WebCore/page/EventHandler.cpp
>===================================================================
>--- Source/WebCore/page/EventHandler.cpp	(revision 234680)
>+++ Source/WebCore/page/EventHandler.cpp	(working copy)
>@@ -3288,7 +3288,7 @@
>         keyDownEvent.setWindowsVirtualKeyCode(CompositionEventKeyCode);
>         keydown = KeyboardEvent::create(keyDownEvent, &m_frame.windowProxy());
>         keydown->setTarget(element);
>-        keydown->setDefaultHandled();
>+        keydown->setIgnoreDefaultEventHandler();
>     }
>     
>     if (accessibilityPreventsEventPropagation(keydown))

Actions: View | Formatted Diff | Diff

Attachments on bug 188370: 346676 | 346801 | 346813