Attachment 346795 Details for Bug 188418 – Patch

[patch] Patch

bug-188418-20180808141850.patch (text/plain), 1.23 KB, created by Alex Christensen on 2018-08-08 14:18:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-08 14:18:51 PDT

Size: 1.23 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 234710)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-08-08  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix possible null dereference in WebBackForwardList::restoreFromState
>+        https://bugs.webkit.org/show_bug.cgi?id=188418
>+        <rdar://problem/42531726>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebBackForwardList.cpp:
>+        (WebKit::WebBackForwardList::restoreFromState):
>+
> 2018-08-08  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r234314, r234320, and r234321.
>Index: Source/WebKit/UIProcess/WebBackForwardList.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebBackForwardList.cpp	(revision 234663)
>+++ Source/WebKit/UIProcess/WebBackForwardList.cpp	(working copy)
>@@ -433,6 +433,9 @@ BackForwardListState WebBackForwardList:
> 
> void WebBackForwardList::restoreFromState(BackForwardListState backForwardListState)
> {
>+    if (!m_page)
>+        return;
>+
>     Vector<Ref<WebBackForwardListItem>> items;
>     items.reserveInitialCapacity(backForwardListState.items.size());
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188418: 346795 | 346802