Attachment 346758 Details for Bug 188404 – Patch

[patch] Patch

bug-188404-20180807234240.patch (text/plain), 1.25 KB, created by Sihui Liu on 2018-08-07 23:42:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-07 23:42:41 PDT

Size: 1.25 KB

patch

obsolete

>Subversion Revision: 234603
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c1076982e6d57cb43a340c20524947140b9e82d3..2e2d6124609594fb088499ec0c4087b7b5da4499 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-07  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Assertion failed in Webcore::Process::setIdentifier()
>+        https://bugs.webkit.org/show_bug.cgi?id=188404
>+        <rdar://problem/43029137>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        App using both WebKit1 and WebKit may crash in WebKit initialization.
>+
>+        * platform/Process.cpp:
>+        (WebCore::Process::setIdentifier):
>+
> 2018-08-06  Charlie Turner  <cturner@igalia.com>
> 
>         Return extracted key ids as an optional
>diff --git a/Source/WebCore/platform/Process.cpp b/Source/WebCore/platform/Process.cpp
>index 6059747c3be7cef7655230a4face04d0d75d2069..c24d9e55c009caa124a59b862615c3659b4204dc 100644
>--- a/Source/WebCore/platform/Process.cpp
>+++ b/Source/WebCore/platform/Process.cpp
>@@ -35,7 +35,7 @@ static std::optional<ProcessIdentifier> globalIdentifier;
> 
> void setIdentifier(ProcessIdentifier processIdentifier)
> {
>-    ASSERT(isMainThread());
>+    ASSERT(isUIThread());
>     globalIdentifier = processIdentifier;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188404: 346758