Attachment 346701 Details for Bug 187973 – WIP patch

[patch] WIP patch

wip.patch (text/plain), 3.56 KB, created by Fujii Hironori on 2018-08-07 02:47:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-08-07 02:47:28 PDT

Size: 3.56 KB

patch

obsolete

>diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
>index aa5b511d1e0..cdcda1ac387 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
>@@ -31,7 +31,6 @@ for layout tests.
> """
> 
> import logging
>-import os.path
> import re
> 
> from webkitpy.layout_tests.models.test_configuration import TestConfigurationConverter
>@@ -139,12 +138,11 @@ class TestExpectationParser(object):
>         if not self._check_test_exists(expectation_line):
>             return
> 
>-        path = os.path.normpath(expectation_line.name)
>-        expectation_line.is_file = self._port.test_isfile(path)
>+        expectation_line.is_file = self._port.test_isfile(expectation_line.name)
>         if expectation_line.is_file:
>-            expectation_line.path = path
>+            expectation_line.path = expectation_line.name
>         else:
>-            expectation_line.path = self._port.normalize_test_name(path)
>+            expectation_line.path = self._port.normalize_test_name(expectation_line.name)
> 
>         self._collect_matching_tests(expectation_line)
> 
>diff --git a/Tools/Scripts/webkitpy/port/base.py b/Tools/Scripts/webkitpy/port/base.py
>index d607cbeb104..5b1b4c0bd39 100644
>--- a/Tools/Scripts/webkitpy/port/base.py
>+++ b/Tools/Scripts/webkitpy/port/base.py
>@@ -700,10 +700,10 @@ class Port(object):
> 
>     def normalize_test_name(self, test_name):
>         """Returns a normalized version of the test name or test directory."""
>-        if test_name.endswith(os.path.sep):
>+        if test_name.endswith(self.TEST_PATH_SEPARATOR):
>             return test_name
>         if self.test_isdir(test_name):
>-            return test_name + os.path.sep
>+            return test_name + self.TEST_PATH_SEPARATOR
>         return test_name
> 
>     def driver_cmd_line_for_logging(self):
>@@ -830,7 +830,9 @@ class Port(object):
>         # Ports that run on windows need to override this method to deal with
>         # filenames with backslashes in them.
>         if filename.startswith(self.layout_tests_dir()):
>-            return self.host.filesystem.relpath(filename, self.layout_tests_dir())
>+            path = self.host.filesystem.relpath(filename, self.layout_tests_dir())
>+            path = path.replace(os.path.sep, self.TEST_PATH_SEPARATOR)
>+            return path
>         else:
>             return self.host.filesystem.abspath(filename)
> 
>@@ -839,7 +841,8 @@ class Port(object):
>         """Returns the full path to the file for a given test name. This is the
>         inverse of relative_test_filename() if no target_host is specified."""
>         host = target_host or self.host
>-        return host.filesystem.join(host.filesystem.map_base_host_path(self.layout_tests_dir()), test_name)
>+        path = test_name.replace(self.TEST_PATH_SEPARATOR, os.path.sep)
>+        return host.filesystem.join(host.filesystem.map_base_host_path(self.layout_tests_dir()), path)
> 
>     def jsc_results_directory(self):
>         return self._build_path()
>diff --git a/Tools/Scripts/webkitpy/port/win.py b/Tools/Scripts/webkitpy/port/win.py
>index 510b6e729c5..c86ff42aaca 100644
>--- a/Tools/Scripts/webkitpy/port/win.py
>+++ b/Tools/Scripts/webkitpy/port/win.py
>@@ -475,8 +475,6 @@ class WinCairoPort(WinPort):
> 
>     DEFAULT_ARCHITECTURE = 'x86_64'
> 
>-    TEST_PATH_SEPARATOR = os.sep
>-
>     def default_baseline_search_path(self):
>         version_name_map = VersionNameMap.map(self.host.platform)
>         if self._os_version < self.VERSION_MIN or self._os_version > self.VERSION_MAX:

Actions: View | Formatted Diff | Diff

Attachments on bug 187973: 346701 | 346702 | 346760 | 346817