Attachment 346682 Details for Bug 188322 – Patch

[patch] Patch

bug-188322-20180806205423.patch (text/plain), 1.69 KB, created by Wenson Hsieh on 2018-08-06 20:54:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-08-06 20:54:24 PDT

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 234614
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 150c745a2d61a6608be50dd2a9ba6fb8c2db3020..e130afeefdc2222474c67cd9f9106b2f1aa1cf40 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Post-review feedback after r234614.
>+        https://bugs.webkit.org/show_bug.cgi?id=188322
>+        <rdar://problem/42455270>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use std::round instead of roundl â there's no reason to go from double to long double precision when rounding.
>+
>+        * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
>+        (rounded):
>+
> 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
>diff --git a/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm b/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
>index c162b87d7ab3415e2d751d69c59a056b966334e8..049d7eae7450169eb7682292ac77e99d418231c7 100644
>--- a/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
>+++ b/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm
>@@ -33,12 +33,13 @@
> #import "UIKitSPI.h"
> #import <WebKit/WKWebViewPrivate.h>
> #import <WebKitLegacy/WebEvent.h>
>+#import <wtf/MathExtras.h>
> 
> @implementation TestWKWebView (KeyboardInputTests)
> 
> static CGRect rounded(CGRect rect)
> {
>-    return CGRectMake(roundl(rect.origin.x), roundl(rect.origin.y), roundl(rect.size.width), roundl(rect.size.height));
>+    return CGRectMake(std::round(rect.origin.x), std::round(rect.origin.y), std::round(rect.size.width), std::round(rect.size.height));
> }
> 
> - (void)waitForCaretViewFrameToBecome:(CGRect)frame

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188322: 346566 | 346569 | 346595 | 346596 | 346597 | 346635 | 346682