Attachment 346666 Details for Bug 187648 – Patch

[patch] Patch

bug-187648-20180806170746.patch (text/plain), 2.52 KB, created by Sihui Liu on 2018-08-06 17:07:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-06 17:07:47 PDT

Size: 2.52 KB

patch

obsolete

>Subversion Revision: 234603
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 3d372c4573d4b096dd0b182de0a8b2bac6413537..2016f2a553e2e82d40bcc20a9ded6707e7f68b72 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-06  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ MacOS iOS ] Layout Test storage/indexeddb/modern/opendatabase-after-storage-crash.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=187648
>+        <rdar://problem/42405935>
>+
>+        Add an early exit so test does not call waitUntilDone after test ends.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/wk2/TestExpectations:
>+        * storage/indexeddb/modern/opendatabase-after-storage-crash.html:
>+
> 2018-08-06  Truitt Savell  <tsavell@apple.com>
> 
>         storage/indexeddb/modern/opendatabase-after-storage-crash.html is causing tests in directory svg/ to timeout at random
>diff --git a/LayoutTests/platform/wk2/TestExpectations b/LayoutTests/platform/wk2/TestExpectations
>index 7dfaa7c52c35349530ecebd0284b09c80b66c166..39ebc2e8254e362c6366ad6d73c681a67962ff11 100644
>--- a/LayoutTests/platform/wk2/TestExpectations
>+++ b/LayoutTests/platform/wk2/TestExpectations
>@@ -732,7 +732,7 @@ http/tests/navigation/process-swap-window-open.html [ Pass ]
> http/wpt/cross-origin-resource-policy/ [ Pass ]
> 
> http/tests/navigation/useragent-reload.php [ Pass ]
>-webkit.org/b/187931 storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Skip ]
>+storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Pass ]
> 
> 
> ### END OF (5) Progressions, expected successes that are expected failures in WebKit1.
>diff --git a/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html b/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html
>index 44d73d42d09cfc7906b8e34ac991822ff07b7d88..70ed44b484c774dc35fad498211d498aa49aa4d9 100644
>--- a/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html
>+++ b/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html
>@@ -46,10 +46,12 @@ request.onupgradeneeded = function(e) {
> 		document.body.innerHTML = "Successfully opened database with version " + versionToOpen + ".";
> 		shouldBeEqualToString('sessionStorage[storageKey]', 'Made it');
> 
>-		if (window.testRunner)
>+		if (window.testRunner) {
> 			testRunner.notifyDone();
>+			return;
>+		}
> 	}
>-	
>+
> 	sessionStorage.doneFirstLoad = true;
> 
> 	// Set an error handler on the database connection so once the storage process terminates we know to continue the test

Actions: View | Formatted Diff | Diff

Attachments on bug 187648: 345413 | 345490 | 346666 | 346852