Attachment 346662 Details for Bug 188361 – Patch

[patch] Patch

file_188361.txt (text/plain), 3.30 KB, created by David Quesada on 2018-08-06 16:05:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Quesada

Created: 2018-08-06 16:05:22 PDT

Size: 3.30 KB

patch

obsolete

>commit 77b0194bec8bc1968ad461f8fdf6d4246d59eff8
>Author: David Quesada <david_quesada@apple.com>
>Date:   Mon Aug 6 16:03:46 2018 -0700
>
>    webkitdirs.pm should default to iPhone SE for 64-bit testing
>    https://bugs.webkit.org/show_bug.cgi?id=188361
>    
>    Reviewed by NOBODY (OOPS!).
>    
>    * Scripts/webkitdirs.pm:
>    (findOrCreateSimulatorForIOSDevice):
>    * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
>    (parse_args):
>
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 150c745a2d6..d1aa73202e4 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-06  David Quesada  <david_quesada@apple.com>
>+
>+        webkitdirs.pm should default to iPhone SE for 64-bit testing
>+        https://bugs.webkit.org/show_bug.cgi?id=188361
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitdirs.pm:
>+        (findOrCreateSimulatorForIOSDevice):
>+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
>+        (parse_args):
>+
> 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
>diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm
>index 9ca79dc5134..2f39c7c433f 100755
>--- a/Tools/Scripts/webkitdirs.pm
>+++ b/Tools/Scripts/webkitdirs.pm
>@@ -2670,8 +2670,8 @@ sub findOrCreateSimulatorForIOSDevice($)
>     my $simulatorName;
>     my $simulatorDeviceType;
>     if (architecture() eq "x86_64") {
>-        $simulatorName = "iPhone 5s " . $simulatorNameSuffix;
>-        $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5s";
>+        $simulatorName = "iPhone SE " . $simulatorNameSuffix;
>+        $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-SE";
>     } else {
>         $simulatorName = "iPhone 5 " . $simulatorNameSuffix;
>         $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5";
>diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
>index 86872c955f4..ced6b9db88b 100755
>--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
>@@ -296,7 +296,7 @@ def parse_args(args):
>         optparse.make_option('--no-install', action='store_const', const=False, default=True, dest='install',
>             help='Skip install step for device and simulator testing'),
>         optparse.make_option('--version', help='Specify the version of iOS to be used. By default, this will adopt the runtime for iOS Simulator.'),
>-        optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone 5s)'),
>+        optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone SE)'),
>         optparse.make_option('--dedicated-simulators', action="store_true", default=False,
>             help="If set, dedicated iOS simulators will always be created.  If not set, the script will attempt to use any currently running simulator."),
>         optparse.make_option('--show-touches', action="store_true", default=False, help="If set, a small dot will be shown where the generated touches are. Helpful for debugging touch tests."),

Flags:

dbates: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188361: 346662