Attachment 346661 Details for Bug 90068 – Patch

[patch] Patch

bug-90068-20180806150401.patch (text/plain), 3.48 KB, created by Daniel Bates on 2018-08-06 15:04:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-08-06 15:04:02 PDT

Size: 3.48 KB

patch

obsolete

>Subversion Revision: 234615
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0a16baa82ed47127e2529345d498d415f5017770..5d8e0e9661bbcaf6b096a594e2289cf53c5792c7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-06  Daniel Bates  <dabates@apple.com>
>+
>+        Setting table layout to fixed causes incorrect cell width calculations
>+        https://bugs.webkit.org/show_bug.cgi?id=90068
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Derived from the test case written by Pravin D.
>+
>+        Add a test case to ensure we do not regress cell width computation in fixed table layout
>+        when colspan is greater than the number of columns in the table.
>+
>+        * fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html: Added.
>+        * fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html: Added.
>+
> 2018-08-03  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed test gardening for mac-wk1.
>diff --git a/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html b/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..6ff7de2a5f071a5c91ff90ce30ca1a80a69cbb76
>--- /dev/null
>+++ b/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html
>@@ -0,0 +1,38 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<style>
>+table, tr, td {
>+    border: 1px solid black;
>+}
>+
>+td {
>+    width: 1%;
>+}
>+table {
>+    background: red;
>+}
>+tr {
>+    background: green;
>+    height: 35px;
>+}
>+</style>
>+</head>
>+<body>
>+<p>This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan &gt; than the number of columns.</p>
>+<table cellspacing="0" cellspacing="0" width="100%" style="table-layout: fixed;">
>+    <tr>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td style="width:94%;"></td>
>+    </tr>
>+    <tr>
>+        <td colspan="7" style="height:24px;width:100%"></td>
>+    </tr>
>+</table>
>+</body>
>+</html>
>diff --git a/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html b/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..ea61a6a451cfda8be386c6dc0db4f349fe3cd397
>--- /dev/null
>+++ b/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html
>@@ -0,0 +1,38 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<style>
>+table, tr, td {
>+    border: 1px solid black;
>+}
>+
>+td {
>+    width: 1%;
>+}
>+table {
>+    background: red;
>+}
>+tr {
>+    background: green;
>+    height: 35px;
>+}
>+</style>
>+</head>
>+<body>
>+<p>This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan &gt; than the number of columns.</p>
>+<table cellspacing="0" cellspacing="0" width="100%" style="table-layout: fixed;">
>+    <tr>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td></td>
>+        <td style="width:94%;"></td>
>+    </tr>
>+    <tr>
>+        <td colspan="10" style="height:24px;width:100%"></td>
>+    </tr>
>+</table>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 90068: 149731 | 153654 | 155067 | 155108 | 346661