Attachment 346659 Details for Bug 188353 – Fixes the test

[patch] Fixes the test

bug-188353-20180806144724.patch (text/plain), 1.71 KB, created by Ryosuke Niwa on 2018-08-06 14:47:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-08-06 14:47:25 PDT

Size: 1.71 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 234618)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-06  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
>+        https://bugs.webkit.org/show_bug.cgi?id=188353
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Rely on GCController.collect() instead of allocating 1,000,000 objects in WebKitTestRunner / DumpRenderTree
>+        so that debug builders won't timeout.
>+
>+        * fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html:
>+
> 2018-08-06  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
>Index: LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html
>===================================================================
>--- LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html	(revision 234617)
>+++ LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html	(working copy)
>@@ -13,10 +13,12 @@ for (let i = 0; i < 10; i++) {
>     iframe.contentWindow.eval(`
>         window.customElements.someProperty = 'storedValue';
>         const a = [];
>-        for (let i = 0; i < 1000000; i++)
>-            a.push({});
>         if (window.GCController)
>             GCController.collect();
>+        else {
>+            for (let i = 0; i < 1000000; i++)
>+                a.push({});
>+        }
>         top.check(window.customElements.someProperty);`);
>     iframe.remove();
> }

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188353: 346659