Attachment 346647 Details for Bug 188352 – Patch

[patch] Patch

bug-188352-20180806132238.patch (text/plain), 3.08 KB, created by Alex Christensen on 2018-08-06 13:22:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-06 13:22:39 PDT

Size: 3.08 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 234615)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-08-06  Alex Christensen  <achristensen@webkit.org>
>+
>+        Use 1-byte enum class for Document::StandaloneStatus
>+        https://bugs.webkit.org/show_bug.cgi?id=188352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * dom/Document.cpp:
>+        (WebCore::Document::setXMLStandalone):
>+        * dom/Document.h:
>+        (WebCore::Document::xmlStandalone const):
>+        * editing/MarkupAccumulator.cpp:
>+        (WebCore::MarkupAccumulator::appendXMLDeclaration):
>+
> 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234569.
>Index: Source/WebCore/dom/Document.cpp
>===================================================================
>--- Source/WebCore/dom/Document.cpp	(revision 234514)
>+++ Source/WebCore/dom/Document.cpp	(working copy)
>@@ -1350,7 +1350,7 @@ ExceptionOr<void> Document::setXMLVersio
> 
> void Document::setXMLStandalone(bool standalone)
> {
>-    m_xmlStandalone = standalone ? Standalone : NotStandalone;
>+    m_xmlStandalone = standalone ? StandaloneStatus::Standalone : StandaloneStatus::NotStandalone;
> }
> 
> void Document::setDocumentURI(const String& uri)
>Index: Source/WebCore/dom/Document.h
>===================================================================
>--- Source/WebCore/dom/Document.h	(revision 234514)
>+++ Source/WebCore/dom/Document.h	(working copy)
>@@ -475,8 +475,8 @@ public:
> 
>     String xmlEncoding() const { return m_xmlEncoding; }
>     String xmlVersion() const { return m_xmlVersion; }
>-    enum StandaloneStatus { StandaloneUnspecified, Standalone, NotStandalone };
>-    bool xmlStandalone() const { return m_xmlStandalone == Standalone; }
>+    enum class StandaloneStatus : uint8_t { Unspecified, Standalone, NotStandalone };
>+    bool xmlStandalone() const { return m_xmlStandalone == StandaloneStatus::Standalone; }
>     StandaloneStatus xmlStandaloneStatus() const { return m_xmlStandalone; }
>     bool hasXMLDeclaration() const { return m_hasXMLDeclaration; }
> 
>@@ -1682,7 +1682,7 @@ private:
> 
>     String m_xmlEncoding;
>     String m_xmlVersion;
>-    StandaloneStatus m_xmlStandalone { StandaloneUnspecified };
>+    StandaloneStatus m_xmlStandalone { StandaloneStatus::Unspecified };
>     bool m_hasXMLDeclaration { false };
> 
>     String m_contentLanguage;
>Index: Source/WebCore/editing/MarkupAccumulator.cpp
>===================================================================
>--- Source/WebCore/editing/MarkupAccumulator.cpp	(revision 234514)
>+++ Source/WebCore/editing/MarkupAccumulator.cpp	(working copy)
>@@ -376,7 +376,7 @@ void MarkupAccumulator::appendXMLDeclara
>         result.appendLiteral("\" encoding=\"");
>         result.append(encoding);
>     }
>-    if (document.xmlStandaloneStatus() != Document::StandaloneUnspecified) {
>+    if (document.xmlStandaloneStatus() != Document::StandaloneStatus::Unspecified) {
>         result.appendLiteral("\" standalone=\"");
>         if (document.xmlStandalone())
>             result.appendLiteral("yes");

Actions: View | Formatted Diff | Diff

Attachments on bug 188352: 346647