WebKit Bugzilla
Attachment 346628 Details for
Bug 184325
: fetch() with subresource integrity crashes on zero length body
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-184325-20180806173646.patch (text/plain), 2.06 KB, created by
Rob Buis
on 2018-08-06 08:36:47 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Rob Buis
Created:
2018-08-06 08:36:47 PDT
Size:
2.06 KB
patch
obsolete
>Subversion Revision: 234601 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index b0fa68f4d9f33b0fabf232da698e612e943d968c..2832b5698439c5166da5c6e99be41cb583c3eb80 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2018-08-06 Rob Buis <rbuis@igalia.com> >+ >+ fetch() with subresource integrity crashes on zero length body >+ https://bugs.webkit.org/show_bug.cgi?id=184325 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests (OOPS!). >+ >+ * loader/DocumentThreadableLoader.cpp: >+ (WebCore::DocumentThreadableLoader::didFinishLoading): >+ > 2018-08-06 Frederic Wang <fwang@igalia.com> > > Make two-arguments versions of scrollBy/scrollTo depend on the one-argument versions >diff --git a/Source/WebCore/loader/DocumentThreadableLoader.cpp b/Source/WebCore/loader/DocumentThreadableLoader.cpp >index 0525bf615ec1e5cc0f5eeee0e35bb9e912b2e8ef..42d7ee96aaf7d9ef56f1d4cb245b34eca03392a0 100644 >--- a/Source/WebCore/loader/DocumentThreadableLoader.cpp >+++ b/Source/WebCore/loader/DocumentThreadableLoader.cpp >@@ -449,12 +449,14 @@ void DocumentThreadableLoader::didFinishLoading(unsigned long identifier) > > if (options().filteringPolicy == ResponseFilteringPolicy::Disable) { > m_client->didReceiveResponse(identifier, response); >- m_client->didReceiveData(m_resource->resourceBuffer()->data(), m_resource->resourceBuffer()->size()); >+ if (m_resource->resourceBuffer()) >+ m_client->didReceiveData(m_resource->resourceBuffer()->data(), m_resource->resourceBuffer()->size()); > } else { > ASSERT(response.type() == ResourceResponse::Type::Default); > > m_client->didReceiveResponse(identifier, ResourceResponseBase::filter(response)); >- m_client->didReceiveData(m_resource->resourceBuffer()->data(), m_resource->resourceBuffer()->size()); >+ if (m_resource->resourceBuffer()) >+ m_client->didReceiveData(m_resource->resourceBuffer()->data(), m_resource->resourceBuffer()->size()); > } > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 184325
:
337247
|
346628
|
346689
|
346691
|
346692
|
346694
|
346696
|
346705