Attachment 346620 Details for Bug 188343 – Patch

[patch] Patch

bug-188343-20180806115808.patch (text/plain), 2.20 KB, created by Frédéric Wang (:fredw) on 2018-08-06 02:58:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2018-08-06 02:58:09 PDT

Size: 2.20 KB

patch

obsolete

>Subversion Revision: 234596
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b0fa68f4d9f33b0fabf232da698e612e943d968c..dd0faec2e94ff4298c036f529a348d74825942b3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-08-06  Frederic Wang  <fwang@igalia.com>
>+
>+        Make DOMWindow::scrollBy rely on DOMWindow::scrollTo
>+        https://bugs.webkit.org/show_bug.cgi?id=188343
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch makes DOMWindow::scrollBy rely on DOMWindow::scrollTo in order to perform actual
>+        scrolling of the view. In particular, this reduces the number of code path to modify in order
>+        to implement the ScrollBehavior option (bug 188043). The only change is an optimization when
>+        scrolling to position (0, 0) but it is not observable.
>+
>+        No new tests, behavior unchanged and already tested.
>+
>+        * page/DOMWindow.cpp:
>+        (WebCore::DOMWindow::scrollBy const): Add the current view position to the scrollBy offset in
>+        order to obtain the scrollTo offset.
>+
> 2018-08-06  Frederic Wang  <fwang@igalia.com>
> 
>         Make two-arguments versions of scrollBy/scrollTo depend on the one-argument versions
>diff --git a/Source/WebCore/page/DOMWindow.cpp b/Source/WebCore/page/DOMWindow.cpp
>index 73073263639f02cf9128bd44586012a481deaa7f..50254d7a66dee7cb6b170a14508a6981e409dc8d 100644
>--- a/Source/WebCore/page/DOMWindow.cpp
>+++ b/Source/WebCore/page/DOMWindow.cpp
>@@ -1591,8 +1591,9 @@ void DOMWindow::scrollBy(const ScrollToOptions& options) const
>         return;
> 
>     ScrollToOptions scrollToOptions = normalizeNonFiniteCoordinatesOrFallBackTo(options, 0, 0);
>-    IntSize scaledOffset(view->mapFromCSSToLayoutUnits(scrollToOptions.left.value()), view->mapFromCSSToLayoutUnits(scrollToOptions.top.value()));
>-    view->setContentsScrollPosition(view->contentsScrollPosition() + scaledOffset);
>+    scrollToOptions.left.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().x());
>+    scrollToOptions.top.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y());
>+    scrollTo(scrollToOptions);
> }
> 
> void DOMWindow::scrollTo(double x, double y, ScrollClamping clamping) const

Actions: View | Formatted Diff | Diff

Attachments on bug 188343: 346620