Attachment 346613 Details for Bug 187802 – Patch

[patch] Patch

bug-187802-20180806073538.patch (text/plain), 3.36 KB, created by Frédéric Wang (:fredw) on 2018-08-05 22:35:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2018-08-05 22:35:39 PDT

Size: 3.36 KB

patch

obsolete

>Subversion Revision: 234586
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 09f09c225aa06887f41ba8943a992a3c147c0e40..3d2cb80331a7e7fb986fd67701aae741df5afd60 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-30  Frederic Wang  <fwang@igalia.com>
>+
>+        ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document
>+        https://bugs.webkit.org/show_bug.cgi?id=187802
>+
>+        The assertion has been removed in bug 188327. This patch updates the test expectations and
>+        add some non-regression test to verify different cases of XML custom element construction.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestExpectations: This test no longer crashes but times out because of bug 187800.
>+        * fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt: Added.
>+        * fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg: Added.
>+
> 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         Add support for microtasks in workers
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 12a66bca1e8f17ad014d3071f39bf86ead89dac9..b88ef6a9a12cf937d003667acf10d9921e68cb51 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -570,7 +570,7 @@ imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-elemen
> 
> # WPT tests for custom elements
> webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/Document-createElement-svg.svg [ Skip ]
>-webkit.org/b/187802 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
>+webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
> 
> # selectors
> webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-001.html [ ImageOnlyFailure ]
>diff --git a/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt b/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..654ddf7f17efab58e42fabe385257964ae2c5d41
>--- /dev/null
>+++ b/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt
>@@ -0,0 +1 @@
>+This test passes if it does not crash.
>diff --git a/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg b/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg
>new file mode 100644
>index 0000000000000000000000000000000000000000..3b16db0cfbbd84d9830775f0c036521dfcf365f1
>--- /dev/null
>+++ b/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg
>@@ -0,0 +1,16 @@
>+<?xml version="1.0" encoding="utf-8"?>
>+<svg:svg xmlns:svg="http://www.w3.org/2000/svg"
>+         xmlns="http://www.w3.org/1999/xhtml">
>+<svg:text>This test passes if it does not crash.</svg:text>
>+<script><![CDATA[
>+if (testRunner)
>+    testRunner.dumpAsText();
>+class MyElement extends HTMLElement {}
>+customElements.define('my-element', MyElement);
>+]]></script>
>+<my-element></my-element>
>+<element-without-definition></element-without-definition>
>+<script><![CDATA[
>+document.documentElement.insertAdjacentHTML("beforeend", "<my-element></my-element>");
>+]]></script>
>+</svg:svg>

Actions: View | Formatted Diff | Diff

Attachments on bug 187802: 345347 | 345567 | 346067 | 346070 | 346613