WebKit Bugzilla
Attachment 346593 Details for
Bug 188331
: REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch v1
bug-188331-20180804142659.patch (text/plain), 1.53 KB, created by
David Kilzer (:ddkilzer)
on 2018-08-04 12:27:00 PDT
(
hide
)
Description:
Patch v1
Filename:
MIME Type:
Creator:
David Kilzer (:ddkilzer)
Created:
2018-08-04 12:27:00 PDT
Size:
1.53 KB
patch
obsolete
>Subversion Revision: 234092 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index ef79ffda4221f29db15ccadf6d983a72b0d87a86..46482f434b9c1ee445a2a7c225ef3c20c42bd523 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-08-04 David Kilzer <ddkilzer@apple.com> >+ >+ REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable >+ <https://webkit.org/b/188331> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * runtime/TemplateObjectDescriptor.h: >+ (JSC::TemplateObjectDescriptor::TemplateObjectDescriptor): >+ Use `m_rawstrings` instead of `rawStrings` to calculate hash. >+ > 2018-07-22 Yusuke Suzuki <utatane.tea@gmail.com> > > [JSC] GetByIdVariant and InByIdVariant do not need slot base if they are not "hit" variants >diff --git a/Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h b/Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h >index 358ea3cc00ed16322e02e3089b0aae7020827c68..bbe92ed9d1e164bb61ec5538874f873c487622c3 100644 >--- a/Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h >+++ b/Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h >@@ -81,7 +81,7 @@ private: > inline TemplateObjectDescriptor::TemplateObjectDescriptor(StringVector&& rawStrings, OptionalStringVector&& cookedStrings) > : m_rawStrings(WTFMove(rawStrings)) > , m_cookedStrings(WTFMove(cookedStrings)) >- , m_hash(calculateHash(rawStrings)) >+ , m_hash(calculateHash(m_rawStrings)) > { > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188331
: 346593