Attachment 346590 Details for Bug 188330 – Patch

[patch] Patch

bug-188330-20180804102746.patch (text/plain), 2.39 KB, created by Simon Fraser (smfr) on 2018-08-04 10:27:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-08-04 10:27:47 PDT

Size: 2.39 KB

patch

obsolete

>Subversion Revision: 234536
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b6cf83317fe59e470b523e397e8b8e0207f5c1bd..8626d258dace86a39ff636fe09c5a3371d1d7eca 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-04  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Clean up initialization of some RenderLayer members
>+        https://bugs.webkit.org/show_bug.cgi?id=188330
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use initializers for the pointers. No need to initialize LayoutUnits, which initialize to zero.
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::RenderLayer):
>+        * rendering/RenderLayer.h:
>+
> 2018-08-02  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Floating] Add FloatingState::bottom() to enable content height computation for formatting roots.
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index d6cfd6a3a5d931714c830ed5f252c98b1bc6574c..f2f2b66fb67c7c0f5c7dc44f4b4968e44a77289f 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -319,13 +319,6 @@ RenderLayer::RenderLayer(RenderLayerModelObject& rendererLayerModelObject)
>     , m_hasNotIsolatedBlendingDescendantsStatusDirty(false)
> #endif
>     , m_renderer(rendererLayerModelObject)
>-    , m_parent(nullptr)
>-    , m_previous(nullptr)
>-    , m_next(nullptr)
>-    , m_first(nullptr)
>-    , m_last(nullptr)
>-    , m_staticInlinePosition(0)
>-    , m_staticBlockPosition(0)
> {
>     m_isNormalFlowOnly = shouldBeNormalFlowOnly();
>     m_isSelfPaintingLayer = shouldBeSelfPaintingLayer();
>diff --git a/Source/WebCore/rendering/RenderLayer.h b/Source/WebCore/rendering/RenderLayer.h
>index 47fff652cf9aa70f51546485b79668a36b669e6f..5db2cdb7f62b49f9b1d4ad714e486dae88dd364c 100644
>--- a/Source/WebCore/rendering/RenderLayer.h
>+++ b/Source/WebCore/rendering/RenderLayer.h
>@@ -1109,11 +1109,11 @@ private:
> 
>     RenderLayerModelObject& m_renderer;
> 
>-    RenderLayer* m_parent;
>-    RenderLayer* m_previous;
>-    RenderLayer* m_next;
>-    RenderLayer* m_first;
>-    RenderLayer* m_last;
>+    RenderLayer* m_parent { nullptr };
>+    RenderLayer* m_previous { nullptr };
>+    RenderLayer* m_next { nullptr };
>+    RenderLayer* m_first { nullptr };
>+    RenderLayer* m_last { nullptr };
> 
>     // Our current relative position offset.
>     LayoutSize m_offsetForInFlowPosition;

Actions: View | Formatted Diff | Diff

Attachments on bug 188330: 346590 | 346594