Attachment 346570 Details for Bug 188324 – patch

[patch] patch

b-backup.diff (text/plain), 4.19 KB, created by Saam Barati on 2018-08-03 17:54:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-08-03 17:54:24 PDT

Size: 4.19 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 234566)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-08-03  Saam Barati  <sbarati@apple.com>
>+
>+        Give the `jsc` shell the JIT entitlement
>+        https://bugs.webkit.org/show_bug.cgi?id=188324
>+        <rdar://problem/42885806>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This should help us in ensuring the system jsc is able to JIT.
>+
>+        * Configurations/JSC.xcconfig:
>+        * JavaScriptCore.xcodeproj/project.pbxproj:
>+        * allow-jit-macOS.entitlements: Added.
>+
> 2018-08-03  Alex Christensen  <achristensen@webkit.org>
> 
>         Fix spelling of "overridden"
>Index: Source/JavaScriptCore/allow-jit-macOS.entitlements
>===================================================================
>--- Source/JavaScriptCore/allow-jit-macOS.entitlements	(nonexistent)
>+++ Source/JavaScriptCore/allow-jit-macOS.entitlements	(working copy)
>@@ -0,0 +1,8 @@
>+<?xml version="1.0" encoding="UTF-8"?>
>+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
>+<plist version="1.0">
>+<dict>
>+	<key>com.apple.security.cs.allow-jit</key>
>+	<true/>
>+</dict>
>+</plist>
>Index: Source/JavaScriptCore/Configurations/JSC.xcconfig
>===================================================================
>--- Source/JavaScriptCore/Configurations/JSC.xcconfig	(revision 234566)
>+++ Source/JavaScriptCore/Configurations/JSC.xcconfig	(working copy)
>@@ -32,6 +32,7 @@ WK_RELOCATABLE_FRAMEWORKS_LDFLAGS_YES = 
> 
> PRODUCT_NAME = jsc;
> CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = entitlements.plist;
>+CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;
> OTHER_CODE_SIGN_FLAGS[sdk=iphone*] = -i com.apple.jsc;
> 
> // Explicitly add the PrivateHeaders directory to the search path so that generated header files can be found in production builds.
>Index: Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
>===================================================================
>--- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj	(revision 234566)
>+++ Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj	(working copy)
>@@ -3701,6 +3701,8 @@
> 		79CFC6EF1C33B10000C768EA /* LLIntPCRanges.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LLIntPCRanges.h; path = llint/LLIntPCRanges.h; sourceTree = "<group>"; };
> 		79D5CD581C1106A900CECA07 /* SamplingProfiler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SamplingProfiler.cpp; sourceTree = "<group>"; };
> 		79D5CD591C1106A900CECA07 /* SamplingProfiler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SamplingProfiler.h; sourceTree = "<group>"; };
>+		79D7B0E121152FD200FE7C64 /* entitlements.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = entitlements.plist; sourceTree = "<group>"; };
>+		79D7B0E221152FD300FE7C64 /* allow-jit-macOS.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = "allow-jit-macOS.entitlements"; sourceTree = "<group>"; };
> 		79DAE2791E03C82200B526AA /* WasmExceptionType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmExceptionType.h; sourceTree = "<group>"; };
> 		79DFCBDA1D88C59600527D03 /* HasOwnPropertyCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HasOwnPropertyCache.h; sourceTree = "<group>"; };
> 		79EE0BFD1B4AFB85000385C9 /* VariableEnvironment.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VariableEnvironment.cpp; sourceTree = "<group>"; };
>@@ -4941,6 +4943,8 @@
> 				F5C290E60284F98E018635CA /* JavaScriptCorePrefix.h */,
> 				45E12D8806A49B0F00E9DF84 /* jsc.cpp */,
> 				A7C225CC139981F100FF1662 /* KeywordLookupGenerator.py */,
>+				79D7B0E221152FD300FE7C64 /* allow-jit-macOS.entitlements */,
>+				79D7B0E121152FD200FE7C64 /* entitlements.plist */,
> 				1432EBD70A34CAD400717B9F /* API */,
> 				9688CB120ED12B4E001D649F /* assembler */,
> 				0FEC84B21BDACD5E0080FF74 /* b3 */,

Actions: View | Formatted Diff | Diff

Attachments on bug 188324: 346570 | 346579