Attachment 346562 Details for Bug 188126 – Patch

[patch] Patch

patch.txt (text/plain), 1.59 KB, created by Nikita Vasilyev on 2018-08-03 16:47:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-08-03 16:47:23 PDT

Size: 1.59 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0da71d64259..1edbc954b65 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-03  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light
>+        https://bugs.webkit.org/show_bug.cgi?id=188126
>+        <rdar://problem/42674963>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DarkMode.css:
>+        (@media (prefers-dark-interface)):
>+        (.source-code.text-editor > .CodeMirror .issue-widget.warning,): Added.
>+        (.source-code.text-editor > .CodeMirror .issue-widget.error,): Added.
>+
> 2018-08-03  Alex Christensen  <achristensen@webkit.org>
> 
>         Fix spelling of "overridden"
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>index 7620f999d58..ba9f656030d 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>@@ -1039,10 +1039,12 @@
>         --error-background-color: hsl(11, 70%, 32%);
>     }
> 
>+    .source-code.text-editor > .CodeMirror .issue-widget.warning,
>     .source-code.text-editor > .CodeMirror .issue-widget.inline.warning {
>         background-color: var(--warning-background-color);
>     }
> 
>+    .source-code.text-editor > .CodeMirror .issue-widget.error,
>     .source-code.text-editor > .CodeMirror .issue-widget.inline.error {
>         background-color: var(--error-background-color);
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 188126: 345953 | 346562 | 346563