Attachment 346553 Details for Bug 188291 – Patch with reviewer added

[patch] Patch with reviewer added

vao.patch (text/plain), 21.71 KB, created by Justin Fan on 2018-08-03 15:38:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2018-08-03 15:38:20 PDT

Size: 21.71 KB

patch

obsolete

>Subversion Revision: 234382
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 422ba3ddc8018a461ec404ba99901dc1bb78226b..0b0c9c8227278c77021ccda227e989522a016c18 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,28 @@
>+2018-08-02  Justin Fan  <justin_fan@apple.com>
>+
>+        WebGL 2 conformance: vertex_arrays/vertex_array_object.html
>+        https://bugs.webkit.org/show_bug.cgi?id=188291
>+        <rdar://problem/42792709>
>+
>+        Reviewed by Dean Jackson.
>+
>+        Get https://www.khronos.org/registry/webgl/conformance-suites/2.0.0/conformance2/vertex_arrays/vertex-array-object.html 
>+        working on Mac OS and iOS, and check in the new test expectations.
>+
>+        Existing test: webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html
>+
>+        * html/canvas/WebGL2RenderingContext.cpp:
>+        (WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
>+        (WebCore::WebGL2RenderingContext::deleteVertexArray):
>+        * html/canvas/WebGLRenderingContextBase.cpp:
>+        (WebCore::WebGLRenderingContextBase::deleteObject):
>+        * html/canvas/WebGLVertexArrayObject.cpp:
>+        (WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
>+        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
>+        (WebCore::GraphicsContext3D::checkVaryingsPacking const):
>+        (WebCore::GraphicsContext3D::createVertexArray):
>+        (WebCore::GraphicsContext3D::deleteVertexArray):
>+        (WebCore::GraphicsContext3D::isVertexArray):
>+        (WebCore::GraphicsContext3D::bindVertexArray):
>+
> 2018-07-30  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGL2] Support compilation of GLSL ES version 300 shaders
>diff --git a/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp b/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>index ba82dabab4ad2b2c4f6519854c54cee7081b8cf4..b87f9fdfcd694be9c971a79b709d2725006aa7e4 100644
>--- a/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>+++ b/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
>@@ -95,7 +95,11 @@ void WebGL2RenderingContext::initializeVertexArrayObjects()
> {
>     m_defaultVertexArrayObject = WebGLVertexArrayObject::create(*this, WebGLVertexArrayObject::Type::Default);
>     addContextObject(*m_defaultVertexArrayObject);
>+#if USE(OPENGL_ES)
>     m_boundVertexArrayObject = m_defaultVertexArrayObject;
>+#else
>+    bindVertexArray(nullptr); // The default VAO was removed in OpenGL 3.3 but not from WebGL 2; bind the default for WebGL to use.
>+#endif
>     if (!isGLES2Compliant())
>         initVertexAttrib0();
> }
>@@ -1063,7 +1067,11 @@ void WebGL2RenderingContext::deleteVertexArray(WebGLVertexArrayObject* arrayObje
>         return;
>     
>     if (!arrayObject->isDefaultObject() && arrayObject == m_boundVertexArrayObject)
>+#if USE(OPENGL_ES)
>         setBoundVertexArrayObject(nullptr);
>+#else
>+        bindVertexArray(nullptr); // The default VAO was removed in OpenGL 3.3 but not from WebGL 2; bind the default for WebGL to use.
>+#endif
>     
>     arrayObject->deleteObject(graphicsContext3D());
> }
>diff --git a/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp b/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
>index fe8375b0abb1098ab9fc9c4d9dd089f2c8e78430..a63c2c5a6518d1cce2f37621fbcab02791ba9da9 100644
>--- a/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
>+++ b/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
>@@ -1768,6 +1768,8 @@ bool WebGLRenderingContextBase::deleteObject(WebGLObject* object)
>         synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "delete", "object does not belong to this context");
>         return false;
>     }
>+    if (object->isDeleted())
>+        return false;
>     if (object->object())
>         // We need to pass in context here because we want
>         // things in this context unbound.
>diff --git a/Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp b/Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
>index 89ae21f33ef8588cd18d4031c857aa8a144e5540..1b46b7b4e86e16bb6af803adc5a01d365c869f94 100644
>--- a/Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
>+++ b/Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
>@@ -46,13 +46,13 @@ WebGLVertexArrayObject::~WebGLVertexArrayObject()
> WebGLVertexArrayObject::WebGLVertexArrayObject(WebGLRenderingContextBase& context, Type type)
>     : WebGLVertexArrayObjectBase(context, type)
> {
>-    switch (m_type) {
>-    case Type::Default:
>-        break;
>-    case Type::User:
>-        setObject(this->context()->graphicsContext3D()->createVertexArray());
>-        break;
>-    }
>+#if USE(OPENGL_ES)
>+    if (m_type != Type::User)
>+        return;
>+#else
>+    ASSERT(type != Type::Default || !(this->context()->m_defaultVertexArrayObject));
>+#endif
>+    setObject(this->context()->graphicsContext3D()->createVertexArray());
> }
> 
> void WebGLVertexArrayObject::deleteObjectImpl(GraphicsContext3D* context3d, Platform3DObject object)
>diff --git a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>index f41236e00306da0fe7eae0be567e913b8e643b22..c5c3a88281f081135037952c422ca78f974af871 100644
>--- a/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>+++ b/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
>@@ -399,7 +399,9 @@ bool GraphicsContext3D::checkVaryingsPacking(Platform3DObject vertexShader, Plat
>         variables.push_back(varyingSymbol);
> 
>     GC3Dint maxVaryingVectors = 0;
>-#if !USE(OPENGL_ES)
>+#if USE(OPENGL_ES)
>+    ::glGetIntegerv(MAX_VARYING_VECTORS, &maxVaryingVectors);
>+#else
>     if (m_isForWebGL2)
>         ::glGetIntegerv(GL_MAX_VARYING_VECTORS, &maxVaryingVectors);
>     else {
>@@ -407,8 +409,6 @@ bool GraphicsContext3D::checkVaryingsPacking(Platform3DObject vertexShader, Plat
>         ::glGetIntegerv(GL_MAX_VARYING_FLOATS, &maxVaryingFloats);
>         maxVaryingVectors = maxVaryingFloats / 4;
>     }
>-#else
>-    ::glGetIntegerv(MAX_VARYING_VECTORS, &maxVaryingVectors);
> #endif
>     return sh::CheckVariablesWithinPackingLimits(maxVaryingVectors, variables);
> }
>@@ -1525,10 +1525,8 @@ Platform3DObject GraphicsContext3D::createVertexArray()
> {
>     makeContextCurrent();
>     GLuint array = 0;
>-#if !USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))
>-    glGenVertexArrays(1, &array);
>-#elif defined(GL_APPLE_vertex_array_object) && GL_APPLE_vertex_array_object
>-    glGenVertexArraysAPPLE(1, &array);
>+#if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
>+    ::glGenVertexArrays(1, &array);
> #endif
>     return array;
> }
>@@ -1539,10 +1537,8 @@ void GraphicsContext3D::deleteVertexArray(Platform3DObject array)
>         return;
>     
>     makeContextCurrent();
>-#if !USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))
>-    glDeleteVertexArrays(1, &array);
>-#elif defined(GL_APPLE_vertex_array_object) && GL_APPLE_vertex_array_object
>-    glDeleteVertexArraysAPPLE(1, &array);
>+#if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
>+    ::glDeleteVertexArrays(1, &array);
> #endif
> }
> 
>@@ -1552,10 +1548,8 @@ GC3Dboolean GraphicsContext3D::isVertexArray(Platform3DObject array)
>         return GL_FALSE;
>     
>     makeContextCurrent();
>-#if !USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))
>-    return glIsVertexArray(array);
>-#elif defined(GL_APPLE_vertex_array_object) && GL_APPLE_vertex_array_object
>-    return glIsVertexArrayAPPLE(array);
>+#if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
>+    return ::glIsVertexArray(array);
> #endif
>     return GL_FALSE;
> }
>@@ -1563,12 +1557,8 @@ GC3Dboolean GraphicsContext3D::isVertexArray(Platform3DObject array)
> void GraphicsContext3D::bindVertexArray(Platform3DObject array)
> {
>     makeContextCurrent();
>-#if !USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))
>-    glBindVertexArray(array);
>-#elif defined(GL_APPLE_vertex_array_object) && GL_APPLE_vertex_array_object
>-    glBindVertexArrayAPPLE(array);
>-#else
>-    UNUSED_PARAM(array);
>+#if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
>+    ::glBindVertexArray(array);
> #endif
> }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 39fd83f2d616e83e22bf6ea50468ac8781105834..1be9b6e8bde924c58b6e81791dbafac5b0817fbd 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,34 @@
>+2018-08-02  Justin Fan  <justin_fan@apple.com>
>+
>+        WebGL 2 conformance: vertex_arrays/vertex_array_object.html
>+        https://bugs.webkit.org/show_bug.cgi?id=188291
>+        <rdar://problem/42792709>
>+
>+        Get https://www.khronos.org/registry/webgl/conformance-suites/2.0.0/conformance2/vertex_arrays/vertex-array-object.html 
>+        working on Mac OS and iOS, and check in the new test expectations.
>+
>+        Reviewed by Dean Jackson.
>+
>+        * TestExpectations: No longer skipping vertex_arrays tests.
>+        The following FAILed before this patch but are now expecting PASSes.
>+        * webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt:
>+        * webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt:
>+
> 2018-07-30  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGL2] Support compilation of GLSL ES version 300 shaders
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 2c7f6dc1be9e844eb6ce226f01e98c6e6dcd75ba..e3b923fc93f6fff5d9215c32a20c582a971f6523 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -2055,6 +2055,7 @@ webkit.org/b/186574 media/video-buffering-allowed.html [ Pass Failure ]
> # All WebGL 1 and 2 tests for now
> webgl/2.0.0 [ Skip ]
> webgl/2.0.0/conformance2/glsl3 [ Pass ]
>+webgl/2.0.0/conformance2/vertex_arrays [ Pass ]
> 
> imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-row-001.xht [ ImageOnlyFailure ]
> imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-style-008.html [ ImageOnlyFailure ]
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt
>index 31c073c87af6903fdcbbc78562746f0a77777dd4..221b91a0bfd7af2dc3137cc2bdadc0a15012dc9f 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-as-return-value.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt
>index 4471c3c59a2c4fd8681047b788a1f897142e55b3..0611499c85f985fd8dc15810051a7974b85e8519 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-assign-constructor.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt
>index d8d2d398fa0d7472617d5ebfabcba00bc39348be..1ea955c8df98a0e8a5954fd9de9e4669be449cfa 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-assign.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt
>index 55cdbb4d0f8683383b908217eb99f832b37c65e6..bd1431f235713683b71d9c49f8c633b0fa48d64c 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-complex-indexing.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt
>index 37f4a3c8b4896ede49a41ccbdd021683ae106a43..956f3963780d246fcdc72ecf72e8a7a65c0336ed 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-element-increment.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt
>index 5e126410a331e8fb2ad5b36523dfdd9125d04b36..1c3cc9203bc4e6bf81d0d4391e0358e1167744dc 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-equality.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt
>index 4e589cd45a9946affa6b79fa6fef5ea107ee3b00..50395b1fa048b301e08a82537ec519c832837509 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/array-in-complex-expression.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt
>index 4ba21c518193e0e66f4f509e0435f1787cb5d0e6..dd842ae9940df9983d8a0aca65035c09e96f4d10 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt
>index 6046dda27a24bc95bb0f492c15431cc21b7471fd..23472cd7427ffb3cfbb8d35a616cccea9cd54953 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/compare-structs-containing-arrays.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt
>index 41feea6e94bd2614f7887a80a37e46b6ccff0b8e..a0e726e52300e395cfc75bcc2bcfa89684ba9195 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/const-array-init.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt
>index 43b737619cf1bd20b426fbdecdf9ac56a63a7091..73617105bc6c36dd9bbd409048b44fe671dacc65 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/frag-depth.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt
>index fe9a0ea79fbedfa5a92dd6bdb2d2de2783ac7d8d..de6a5006b5b101d33b7b9476bd626644447074d1 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/loops-with-side-effects.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt
>index 5e556afa60b94347cc4b8c15816fcf8577b607eb..dfb68963b486d7c99bd9c4a2d217c2df30b82833 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/no-attribute-vertex-shader.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt
>index f21c48684bbbbddb0881194377d7d8c080a27e74..496d8e857243e2c5c98c01435467bbc6a0ed34f9 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/short-circuiting-in-loop-condition.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt
>index 76f8d81409c6fe45ac3cc91a4bafc5f3c65a992e..9a723a6b6edf8315a527b33645ef47c5a8a54a51 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/tricky-loop-conditions.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt
>index e234abe554fb836c4bb201cba3b7a7eb48591057..4372fc34fee4e87e141ae90d10b29040d3900104 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/vector-dynamic-indexing.html
>-FAIL
>+PASS
> 
>diff --git a/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt b/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt
>index 921ba2a770c0819c2991ec31831d22fc7065faf6..a2a0b5e143d2d69b959adaeda7f2c0c3cc538a8f 100644
>--- a/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt
>+++ b/LayoutTests/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt
>@@ -1,5 +1,5 @@
> This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
> 
> Test: ../../resources/webgl_test_files/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug.html
>-FAIL
>+PASS
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188291: 346439 | 346442 | 346443 | 346445 | 346450 | 346456 | 346491 | 346553 | 346555