Attachment 346516 Details for Bug 188317 – PATCH

[patch] PATCH

188317.diff (text/plain), 2.81 KB, created by Basuke Suzuki on 2018-08-03 12:24:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-03 12:24:22 PDT

Size: 2.81 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5ef8510283a..8d3f9d47f67 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [LayoutTests][websocket] Return correct value even when cookie is not set.
>+        https://bugs.webkit.org/show_bug.cgi?id=188317
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        > ws://127.0.0.1:8880/websocket/tests/hybi/echo-cookie_wsh.py
>+        This web socket script throw exception when cookie is not set. That is ended up with
>+        immediate disconnection and causes timeout for failure tests which makes debugging hard.
>+
>+        * http/tests/websocket/tests/hybi/echo-cookie_wsh.py:
>+        (web_socket_transfer_data):
>+        * platform/wincairo/TestExpectations:
>+
> 2018-08-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
> 
>         [Curl] Test gardening
>diff --git a/LayoutTests/http/tests/websocket/tests/hybi/echo-cookie_wsh.py b/LayoutTests/http/tests/websocket/tests/hybi/echo-cookie_wsh.py
>index faa25f980e0..36715a60b60 100644
>--- a/LayoutTests/http/tests/websocket/tests/hybi/echo-cookie_wsh.py
>+++ b/LayoutTests/http/tests/websocket/tests/hybi/echo-cookie_wsh.py
>@@ -35,4 +35,4 @@ def web_socket_do_extra_handshake(request):
> 
> 
> def web_socket_transfer_data(request):
>-    msgutil.send_message(request,  request.headers_in['Cookie'])
>+    msgutil.send_message(request,  request.headers_in.getheader('Cookie', ""))
>\ No newline at end of file
>diff --git a/LayoutTests/platform/wincairo/TestExpectations b/LayoutTests/platform/wincairo/TestExpectations
>index 2cbf2c6c103..35c2541fe85 100644
>--- a/LayoutTests/platform/wincairo/TestExpectations
>+++ b/LayoutTests/platform/wincairo/TestExpectations
>@@ -913,10 +913,10 @@ http/tests/websocket/tests/hybi/contentextensions [ Failure ]
> http/tests/websocket/tests/hybi/contentextensions/block-cookies.php [ Pass ]
> http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php [ Pass ]
> http/tests/websocket/tests/hybi/deflate-frame-parameter.html [ Failure ]
>-http/tests/websocket/tests/hybi/httponly-cookie.pl [ Timeout Failure ]
>+http/tests/websocket/tests/hybi/httponly-cookie.pl [ Failure ]
> http/tests/websocket/tests/hybi/inspector [ Skip ]
>-http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl [ Timeout Failure ]
>-http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl [ Timeout Failure ]
>+http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl [ Failure ]
>+http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl [ Failure ]
> http/tests/websocket/tests/hybi/upgrade-simple-ws.html [ Pass Failure ]
> http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html [ Failure ]
> http/tests/websocket/tests/hybi/websocket-blocked-from-setting-cookie-as-third-party.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 188317: 346511 | 346515 | 346516