Attachment 346485 Details for Bug 188162 – Patch

[patch] Patch

bug-188162-20180803170135.patch (text/plain), 2.26 KB, created by Ms2ger (he/him; ⌚ UTC+1/+2) on 2018-08-03 08:01:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ms2ger (he/him; ⌚ UTC+1/+2)

Created: 2018-08-03 08:01:37 PDT

Size: 2.26 KB

patch

obsolete

>Subversion Revision: 234359
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bfef6390a7b391a9a7f5dd7cbb568021ed5ee4ad..a9596e6b64a321305f6fea1e4d61ea5cea9e9c99 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-08-03  Ms2ger  <Ms2ger@igalia.com>
>+
>+        [GStreamer] Remove unsound assertions in MediaPlayerPrivateGStreamerBase.
>+        https://bugs.webkit.org/show_bug.cgi?id=188162
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These assertions sometimes fail, and there's a runtime check right
>+        after them anyway.
>+
>+        Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html
>+               fast/canvas/webgl/texImage2D-video-flipY-true.html
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
>+        (WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
>+
> 2018-07-28  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>index e3635d221f936af993fc1932b4eb7ac37057d022..d73f241996e5ab54208e9799bd626f7dde210e38 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
>@@ -938,7 +938,6 @@ bool MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture(Graphics
>     std::unique_ptr<GstVideoFrameHolder> frameHolder = std::make_unique<GstVideoFrameHolder>(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation), true);
> 
>     auto textureID = frameHolder->textureID();
>-    ASSERT(textureID);
>     if (!textureID)
>         return false;
> 
>@@ -966,7 +965,6 @@ NativeImagePtr MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime()
>     std::unique_ptr<GstVideoFrameHolder> frameHolder = std::make_unique<GstVideoFrameHolder>(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation), true);
> 
>     auto textureID = frameHolder->textureID();
>-    ASSERT(textureID);
>     if (!textureID)
>         return nullptr;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188162: 346485 | 346564