Attachment 346477 Details for Bug 188297 – Patch

[patch] Patch

bug-188297-20180803064242.patch (text/plain), 1.87 KB, created by zalan on 2018-08-03 06:42:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-08-03 06:42:43 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 234537
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index aa50efae05a541019fab94e95ab392eb67d83f90..d144bd7212d101747e4b36d85ccfc302c2d3aaa8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-02  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] Do not check margin box while validating geometry.
>+        https://bugs.webkit.org/show_bug.cgi?id=188297
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.
>+
>+        * layout/Verification.cpp:
>+        (WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
>+
> 2018-08-02  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Apply the "10.6.6 Complicated cases" when computing height and margin for the document renderer
>diff --git a/Source/WebCore/layout/Verification.cpp b/Source/WebCore/layout/Verification.cpp
>index e211a7de75977e007b91e4a7036119ed3c79e7a9..23d60af7a1ca90b22d91d8b20a7c3add291ee2e1 100644
>--- a/Source/WebCore/layout/Verification.cpp
>+++ b/Source/WebCore/layout/Verification.cpp
>@@ -134,11 +134,6 @@ static bool outputMismatchingBlockBoxInformationIfNeeded(TextStream& stream, con
>         return true;
>     }
> 
>-    if (renderer.marginBoxRect() != displayBox->nonCollapsedMarginBox()) {
>-        outputRect("marginBox", renderer.marginBoxRect(), displayBox->nonCollapsedMarginBox());
>-        return true;
>-    }
>-
>     if (renderer.borderBoxRect() != displayBox->borderBox()) {
>         outputRect("borderBox", renderer.borderBoxRect(), displayBox->borderBox());
>         return true;
>@@ -154,6 +149,7 @@ static bool outputMismatchingBlockBoxInformationIfNeeded(TextStream& stream, con
>         return true;
>     }
> 
>+    // TODO: The RenderBox::marginBox() does not follow the spec and ignores certain constraints. Skip them for now.
>     return false;
> }
>

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188297: 346452 | 346477