Attachment 346474 Details for Bug 188304 – Patch

[patch] Patch

bug-188304-20180803145227.patch (text/plain), 1.61 KB, created by Ms2ger (he/him; ⌚ UTC+1/+2) on 2018-08-03 05:52:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ms2ger (he/him; ⌚ UTC+1/+2)

Created: 2018-08-03 05:52:29 PDT

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 234359
>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
>index 1caf574b66252c711e44fad8bdf532b6964a4375..981585273fa96f22f6ba057023b9428c0c62e650 100644
>--- a/Source/WebDriver/ChangeLog
>+++ b/Source/WebDriver/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-03  Ms2ger  <Ms2ger@igalia.com>
>+
>+        Fix invalid optional access in WebDriver Session::createTopLevelBrowsingContext.
>+        https://bugs.webkit.org/show_bug.cgi?id=188304
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Session.cpp:
>+        (WebDriver::Session::createTopLevelBrowsingContext): remove incorrect value() call.
>+
> 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
>diff --git a/Source/WebDriver/Session.cpp b/Source/WebDriver/Session.cpp
>index 779be1f089b7d16049b39754209347b7ed450624..bfc73801eedb38813089eaf999f88f692ef8c110 100644
>--- a/Source/WebDriver/Session.cpp
>+++ b/Source/WebDriver/Session.cpp
>@@ -177,7 +177,7 @@ std::optional<String> Session::pageLoadStrategyString() const
> 
> void Session::createTopLevelBrowsingContext(Function<void (CommandResult&&)>&& completionHandler)
> {
>-    ASSERT(!m_toplevelBrowsingContext.value());
>+    ASSERT(!m_toplevelBrowsingContext);
>     m_host->sendCommandToBackend("createBrowsingContext"_s, nullptr, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
>         if (response.isError || !response.responseObject) {
>             completionHandler(CommandResult::fail(WTFMove(response.responseObject)));

Actions: View | Formatted Diff | Diff

Attachments on bug 188304: 346474