Attachment 346435 Details for Bug 188289 – PATCH

[patch] PATCH

188289.diff (text/plain), 1.17 KB, created by Basuke Suzuki on 2018-08-02 17:20:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-02 17:20:51 PDT

Size: 1.17 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 53f6aad0cd2..0253513d964 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [LayoutTests][PHP] Fix old-style script which uses function name as a keyword.
>+        https://bugs.webkit.org/show_bug.cgi?id=188289
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Function name should be passed as a string literal. In PHP, named function is
>+        not the first class citizen.
>+
>+        * http/tests/cookies/resources/echo-cookies.php:
>+
> 2018-08-01  David Fenton  <david_fenton@apple.com>
> 
>         Layout Test editing/selection/update-selection-by-style-change.html is flaky.
>diff --git a/LayoutTests/http/tests/cookies/resources/echo-cookies.php b/LayoutTests/http/tests/cookies/resources/echo-cookies.php
>index 97870f1de64..d9902ff62ce 100644
>--- a/LayoutTests/http/tests/cookies/resources/echo-cookies.php
>+++ b/LayoutTests/http/tests/cookies/resources/echo-cookies.php
>@@ -6,6 +6,6 @@ function echoCookie($value, $name)
> }
> 
> echo "Cookies are:\n";
>-array_walk($_COOKIE, echoCookie);    
>+array_walk($_COOKIE, 'echoCookie');
> 
> ?>

Actions: View | Formatted Diff | Diff

Attachments on bug 188289: 346435