Attachment 346408 Details for Bug 188273 – Patch

[patch] Patch

bug-188273-20180802125316.patch (text/plain), 1.61 KB, created by zalan on 2018-08-02 12:53:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-08-02 12:53:16 PDT

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 234509
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8461acba922f923448a97d06c20b48401d06edb0..ff9e87edf7d4496c911addbbfd048daf02e27157 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-02  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][Floating] Right aligned float's horizontal candidate position is miscomputed.
>+        https://bugs.webkit.org/show_bug.cgi?id=188273
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        rightAlignedBoxLeft is already shifted with the size of the margin box.
>+
>+        * layout/FloatingContext.cpp:
>+        (WebCore::Layout::FloatingContext::alignWithFloatings const):
>+
> 2018-08-02  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Display:Box::rectWithMargin()'s width and height don't include margin left/top.
>diff --git a/Source/WebCore/layout/FloatingContext.cpp b/Source/WebCore/layout/FloatingContext.cpp
>index 036cc1bd200762db7119c1bdd83cc01b9e42f586..9ef047b9d661bd892c052f4fc9eb2929e4eddb4c 100644
>--- a/Source/WebCore/layout/FloatingContext.cpp
>+++ b/Source/WebCore/layout/FloatingContext.cpp
>@@ -216,7 +216,7 @@ LayoutUnit FloatingContext::alignWithFloatings(const FloatingPair& floatingPair,
> 
>     if (auto* rightDisplayBox = floatingPair.right()) {
>         auto rightFloatingBoxLeft = rightDisplayBox->rectWithMargin().left();
>-        return std::max(std::min(rightAlignedBoxLeft, rightFloatingBoxLeft) - marginBoxWidth, leftAlignedBoxLeft);
>+        return std::max(std::min(rightAlignedBoxLeft, rightFloatingBoxLeft - marginBoxWidth), leftAlignedBoxLeft);
>     }
> 
>     return rightAlignedBoxLeft;

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188273: 346408