Attachment 346407 Details for Bug 188272 – Patch

[patch] Patch

bug-188272-20180802124503.patch (text/plain), 1.78 KB, created by zalan on 2018-08-02 12:45:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-08-02 12:45:04 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 234508
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 022455155d042d3e2032e66537c3070296a4e503..f5a297b48111a53c88bab972375ab9bca3eca1ce 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-02  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] Display:Box::rectWithMargin()'s width and height don't include margin left/top.
>+        https://bugs.webkit.org/show_bug.cgi?id=188272
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * layout/displaytree/DisplayBox.h:
>+        (WebCore::Display::Box::rectWithMargin const):
>+
> 2018-08-02  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Floating] Containing block of a float could push the candidate position beyond the current float.
>diff --git a/Source/WebCore/layout/displaytree/DisplayBox.h b/Source/WebCore/layout/displaytree/DisplayBox.h
>index 16a09532da15f3a3ed1852dcd1a7799f7ef8926a..f7e0c6b64098110ff1ef5bb25a4617a9b89feab5 100644
>--- a/Source/WebCore/layout/displaytree/DisplayBox.h
>+++ b/Source/WebCore/layout/displaytree/DisplayBox.h
>@@ -127,7 +127,7 @@ public:
>     LayoutUnit width() const { return borderLeft() + paddingLeft() + contentBoxWidth() + paddingRight() + borderRight(); }
>     LayoutUnit height() const { return borderTop() + paddingTop() + contentBoxHeight() + paddingBottom() + borderBottom(); }
>     Rect rect() const { return { top(), left(), width(), height() }; }
>-    Rect rectWithMargin() const { return { top() - marginTop(), left() - marginLeft(), width() + marginRight(), height() + marginBottom() }; }
>+    Rect rectWithMargin() const { return { top() - marginTop(), left() - marginLeft(), marginLeft() + width() + marginRight(), marginTop() + height() + marginBottom() }; }
> 
>     LayoutUnit marginTop() const;
>     LayoutUnit marginLeft() const;

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188272: 346407