Attachment 346321 Details for Bug 188244 – Patch

[patch] Patch

bug-188244-20180801174418.patch (text/plain), 1.93 KB, created by Ross Kirsling on 2018-08-01 17:44:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-08-01 17:44:19 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 234488
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d4ebb9d9c4133eec5f2d818f451a3b0862c47842..a0038b3bfcac4b85882ef3cf6d7cb402918f1cb8 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
>+        https://bugs.webkit.org/show_bug.cgi?id=188244
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
>+
>+        * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
>+
> 2018-08-01  Nan Wang  <n_wang@apple.com>
> 
>         AX: AOM: Add ARIA IDL Attribute Reflection
>diff --git a/Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp b/Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp
>index 1ed9d2fbb550f71c0c90df215c65a43c78a2567b..039bc11db03b7ae6e5dfe937dd26c1ecb7dbc385 100644
>--- a/Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp
>@@ -62,7 +62,11 @@ TEST(WTF_NeverDestroyed, Construct)
>         }());
>         ASSERT_STREQ(x.get().name, "x");
>     }
>+#if COMPILER(MSVC) && !defined(NDEBUG)
>+    ASSERT_STREQ("construct(name) set-name(x) move-construct(x) destruct(<default>) move-construct(x) destruct(<default>) ", takeLogStr().c_str());
>+#else
>     ASSERT_STREQ("construct(name) set-name(x) move-construct(x) destruct(<default>) ", takeLogStr().c_str());
>+#endif
> 
>     {
>         static NeverDestroyed<LifecycleLogger> x;
>@@ -89,7 +93,11 @@ TEST(WTF_NeverDestroyed, Construct)
>         }());
>         UNUSED_PARAM(x);
>     }
>+#if COMPILER(MSVC) && !defined(NDEBUG)
>+    ASSERT_STREQ("construct(name) set-name(x) move-construct(x) destruct(<default>) move-construct(x) destruct(<default>) ", takeLogStr().c_str());
>+#else
>     ASSERT_STREQ("construct(name) set-name(x) move-construct(x) destruct(<default>) ", takeLogStr().c_str());
>+#endif
> }
> 
> static const Vector<int>& list()

Actions: View | Formatted Diff | Diff

Attachments on bug 188244: 346321