Attachment 346292 Details for Bug 188234 – fix

[patch] fix

188234.diff (text/plain), 1.13 KB, created by Basuke Suzuki on 2018-08-01 13:16:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-01 13:16:15 PDT

Size: 1.13 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bfef6390a7b..2396c94855c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-01  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Bugfix on ResourceHandle::cancel()
>+        https://bugs.webkit.org/show_bug.cgi?id=188234
>+
>+        Reviewed by NOBODY (OOPS!).
>+        Trivial bug. The actual request was not cancelled correctly.
>+
>+        * platform/network/curl/ResourceHandleCurl.cpp:
>+        (WebCore::ResourceHandle::cancel):
>+
> 2018-07-28  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
>diff --git a/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp b/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
>index 56428204168..21731a23677 100644
>--- a/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
>+++ b/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
>@@ -97,7 +97,7 @@ void ResourceHandle::cancel()
> 
>     d->m_cancelled = true;
> 
>-    if (!d->m_curlRequest)
>+    if (d->m_curlRequest)
>         d->m_curlRequest->cancel();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188234: 346292