WebKit Bugzilla
Attachment 346285 Details for
Bug 188230
: Always use MediaPlayback audio category when playing to AppleTV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch.
atv_audio_category_patch.txt (text/plain), 1.58 KB, created by
Eric Carlson
on 2018-08-01 12:05:50 PDT
(
hide
)
Description:
Proposed patch.
Filename:
MIME Type:
Creator:
Eric Carlson
Created:
2018-08-01 12:05:50 PDT
Size:
1.58 KB
patch
obsolete
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 44dd219a253..afd37b9cc14 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-08-01 Eric Carlson <eric.carlson@apple.com> >+ >+ Always use MediaPlayback audio category when playing to AppleTV >+ https://bugs.webkit.org/show_bug.cgi?id=188230 >+ <rdar://problem/42497809> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * platform/audio/cocoa/MediaSessionManagerCocoa.cpp: >+ (PlatformMediaSessionManager::updateSessionState): Check session.isPlayingToWirelessPlaybackTarget(). >+ > 2018-08-01 Eric Carlson <eric.carlson@apple.com> > > [iOS] Remove the delay before setting audio session category added in r233535 >diff --git a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp >index c958c32f7ed..b3e16279df8 100644 >--- a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp >+++ b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.cpp >@@ -72,6 +72,8 @@ void PlatformMediaSessionManager::updateSessionState() > hasWebAudioType = true; > if ((type == PlatformMediaSession::VideoAudio || type == PlatformMediaSession::Audio) && session.canProduceAudio() && session.state() == PlatformMediaSession::Playing) > hasAudibleAudioOrVideoMediaType = true; >+ if (session.isPlayingToWirelessPlaybackTarget()) >+ hasAudibleAudioOrVideoMediaType = true; > return (type == PlatformMediaSession::MediaStreamCapturingAudio); > }); >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188230
:
346282
| 346285