WebKit Bugzilla
Attachment 346281 Details for
Bug 188229
: Allow WebFramePolicyListenerProxy to be used multiple times
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188229-20180801110053.patch (text/plain), 1.97 KB, created by
Alex Christensen
on 2018-08-01 11:00:55 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2018-08-01 11:00:55 PDT
Size:
1.97 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 234461) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2018-08-01 Alex Christensen <achristensen@webkit.org> >+ >+ Allow WebFramePolicyListenerProxy to be used multiple times >+ https://bugs.webkit.org/show_bug.cgi?id=188229 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/WebFramePolicyListenerProxy.cpp: >+ (WebKit::WebFramePolicyListenerProxy::use): >+ (WebKit::WebFramePolicyListenerProxy::download): >+ (WebKit::WebFramePolicyListenerProxy::ignore): >+ > 2018-08-01 Aditya Keerthi <akeerthi@apple.com> > > [iOS] Color picker should have a border when presented in a popover >Index: Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp >=================================================================== >--- Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp (revision 234461) >+++ Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp (working copy) >@@ -42,17 +42,20 @@ WebFramePolicyListenerProxy::WebFramePol > > void WebFramePolicyListenerProxy::use(API::WebsitePolicies* policies, ShouldProcessSwapIfPossible swap) > { >- m_completionHandler(WebCore::PolicyAction::Use, policies, swap); >+ if (m_completionHandler) >+ m_completionHandler(WebCore::PolicyAction::Use, policies, swap); > } > > void WebFramePolicyListenerProxy::download() > { >- m_completionHandler(WebCore::PolicyAction::Download, nullptr, ShouldProcessSwapIfPossible::No); >+ if (m_completionHandler) >+ m_completionHandler(WebCore::PolicyAction::Download, nullptr, ShouldProcessSwapIfPossible::No); > } > > void WebFramePolicyListenerProxy::ignore() > { >- m_completionHandler(WebCore::PolicyAction::Ignore, nullptr, ShouldProcessSwapIfPossible::No); >+ if (m_completionHandler) >+ m_completionHandler(WebCore::PolicyAction::Ignore, nullptr, ShouldProcessSwapIfPossible::No); > } > > } // namespace WebKit
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
cdumez
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188229
: 346281