Attachment 346258 Details for Bug 188107 – Patch for landing

[patch] Patch for landing

bug-188107-20180731214317.patch (text/plain), 4.18 KB, created by Wenson Hsieh on 2018-07-31 21:43:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-07-31 21:43:18 PDT

Size: 4.18 KB

patch

obsolete

>Subversion Revision: 234439
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ca20d1559eac38794790f81d77a6cfa14035ab41..682b224d35e585538fd7cf3704fcbf56adfadead 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Tidy up a layout test introduced in r234436.
>+        https://bugs.webkit.org/show_bug.cgi?id=188107
>+        <rdar://problem/42354250>
>+
>+        Reviewed by Daniel Bates.
>+
>+        The expected output of a test that uses js-test.js should include a description, plus a line that states that
>+        there will be a series of PASS messages, PASS/FAIL output, a successfully parsed line and finally a TEST
>+        COMPLETE line. This patch adjusts a newly introduced test to follow this convention.
>+
>+        * fast/forms/ios/click-should-not-suppress-misspelling-expected.txt:
>+        * fast/forms/ios/click-should-not-suppress-misspelling.html:
>+
> 2018-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Spelling suggestions cannot be selected in focused form controls when zoomed in
>diff --git a/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt b/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt
>index 691e2b4d8afc63bed86fe3bfaf0f9f507d213f3c..01977149c90a35d50b2963624ffe298b4b6c48e3 100644
>--- a/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt
>+++ b/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt
>@@ -1,6 +1,11 @@
>-PASS successfullyParsed is true
>+This test verifies that tapping in a misspelled word selects the misspelled word, and does not cause the selection to collapse after a click event is dispatched. To manually test, tap the input field to bring up the keyboard, and then tap on a part of the word in the input field that is far away from the editing caret. As a result, the contents of the input should be selected and marked as a misspelled word.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
> 
>-TEST COMPLETE
> PASS input.selectionStart is 0
> PASS input.selectionEnd is 7
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
> 
>diff --git a/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html b/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html
>index 07024853b06bf3c3d12346f6c1c3f727c1d5a8c2..383ee1162572e2f43321362cdae1694c963161ac 100644
>--- a/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html
>+++ b/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html
>@@ -18,32 +18,28 @@ input {
> </head>
> <body>
> <input id="input" value="covfefe">
>-</body>
> <script>
> const input = document.getElementById("input");
>+jsTestIsAsync = true;
> 
>-addEventListener("load", async () => {
>-    if (window.testRunner) {
>-        testRunner.dumpAsText();
>-        testRunner.waitUntilDone();
>-    } else {
>-        description(`To manually test, tap the input field to bring up the keyboard, and then tap on a part of the word in
>-            the input field that is far away from the editing caret. As a result, the contents of the input should be
>-            selected and marked as a misspelled word.`);
>-        return;
>-    }
>+description("This test verifies that tapping in a misspelled word selects the misspelled word, and does not cause " +
>+    "the selection to collapse after a click event is dispatched. To manually test, tap the input field to bring up " +
>+    "the keyboard, and then tap on a part of the word in the input field that is far away from the editing caret. As " +
>+    "a result, the contents of the input should be selected and marked as a misspelled word.");
> 
>-    await UIHelper.activateAndWaitForInputSessionAt(100, 150);
>+(async function() {
>+    await UIHelper.activateAndWaitForInputSessionAt(100, 200);
> 
>     input.addEventListener("click", () => {
>         setTimeout(() => {
>             shouldBe("input.selectionStart", "0");
>             shouldBe("input.selectionEnd", "7");
>-            testRunner.notifyDone();
>+            finishJSTest();
>         });
>     });
> 
>-    await UIHelper.tapAt(800, 150);
>-});
>+    UIHelper.tapAt(800, 200);
>+})();
> </script>
>+</body>
> </html>

Actions: View | Formatted Diff | Diff

Attachments on bug 188107: 345938 | 346248 | 346250 | 346258