Attachment 346207 Details for Bug 186751 – Move AnimatedPropertyType to a separate file.

[patch] Move AnimatedPropertyType to a separate file.

186751-22.patch (text/plain), 7.83 KB, created by Said Abou-Hallawa on 2018-07-31 14:45:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2018-07-31 14:45:11 PDT

Size: 7.83 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f3d200fc1aa..d80cd5a11c6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-07-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        [22] Remove the SVG elements' attributes macros
>+        https://bugs.webkit.org/show_bug.cgi?id=186751
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move the enums AnimatedPropertyState and AnimatedPropertyType to a
>+        separate header file. SVGPropertyInfo.h will be deleted later.
>+
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * svg/properties/:SVGAnimatedPropertyType.h: Added.
>+        * svg/properties/SVGPropertyInfo.h:
>+        (): Deleted.
>+
> 2018-07-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         [21] Remove the SVG elements' attributes macros
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index 72d783e29fd..2c15dff67e6 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -1725,6 +1725,7 @@
> 		55FA7FF5210FB6B1005AEFE7 /* SVGAttributeAccessor.h in Headers */ = {isa = PBXBuildFile; fileRef = 55FA7FF4210FB688005AEFE7 /* SVGAttributeAccessor.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		55FA7FF7210FBE3E005AEFE7 /* SVGAttributeRegistry.h in Headers */ = {isa = PBXBuildFile; fileRef = 55FA7FF6210FBE3E005AEFE7 /* SVGAttributeRegistry.h */; };
> 		55FA7FFB2110ECD7005AEFE7 /* SVGZoomAndPanType.h in Headers */ = {isa = PBXBuildFile; fileRef = 55FA7FFA2110ECD7005AEFE7 /* SVGZoomAndPanType.h */; settings = {ATTRIBUTES = (Private, ); }; };
>+		55FA7FFF21110E6E005AEFE7 /* :SVGAnimatedPropertyType.h in Headers */ = {isa = PBXBuildFile; fileRef = 55FA7FFE21110E6E005AEFE7 /* :SVGAnimatedPropertyType.h */; };
> 		5704405A1E53936200356601 /* JSAesCbcCfbParams.h in Headers */ = {isa = PBXBuildFile; fileRef = 570440591E53936200356601 /* JSAesCbcCfbParams.h */; };
> 		5706A6961DDE5C9500A03B14 /* CryptoAlgorithmRsaOaepParams.h in Headers */ = {isa = PBXBuildFile; fileRef = 5706A6951DDE5C9500A03B14 /* CryptoAlgorithmRsaOaepParams.h */; };
> 		5706A6981DDE5E4600A03B14 /* JSRsaOaepParams.h in Headers */ = {isa = PBXBuildFile; fileRef = 5706A6971DDE5E4600A03B14 /* JSRsaOaepParams.h */; };
>@@ -8405,6 +8406,7 @@
> 		55FA7FF9210FDB34005AEFE7 /* SVGAttributeOwnerProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SVGAttributeOwnerProxy.h; sourceTree = "<group>"; };
> 		55FA7FFA2110ECD7005AEFE7 /* SVGZoomAndPanType.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SVGZoomAndPanType.h; sourceTree = "<group>"; };
> 		55FA7FFC2110F813005AEFE7 /* SVGAnimatedPathSegListPropertyTearOff.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = SVGAnimatedPathSegListPropertyTearOff.cpp; sourceTree = "<group>"; };
>+		55FA7FFE21110E6E005AEFE7 /* :SVGAnimatedPropertyType.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ":SVGAnimatedPropertyType.h"; sourceTree = "<group>"; };
> 		570440571E53851600356601 /* CryptoAlgorithmAES_CFBMac.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CryptoAlgorithmAES_CFBMac.cpp; sourceTree = "<group>"; };
> 		570440591E53936200356601 /* JSAesCbcCfbParams.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSAesCbcCfbParams.h; sourceTree = "<group>"; };
> 		5704405B1E53937900356601 /* JSAesCbcCfbParams.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSAesCbcCfbParams.cpp; sourceTree = "<group>"; };
>@@ -15481,6 +15483,7 @@
> 				088A0E03126EF1DB00978F7A /* SVGPropertyTraits.h */,
> 				0880F70D1282B46D00948505 /* SVGStaticListPropertyTearOff.h */,
> 				0813A4E91284132600992511 /* SVGStaticPropertyTearOff.h */,
>+				55FA7FFE21110E6E005AEFE7 /* :SVGAnimatedPropertyType.h */,
> 			);
> 			path = properties;
> 			sourceTree = "<group>";
>@@ -30389,6 +30392,7 @@
> 				A8EA800A0A19516E00A8EF5F /* StyleSheetList.h in Headers */,
> 				BC5EB5E50E81BF6D00B25965 /* StyleSurroundData.h in Headers */,
> 				BC5EB8100E81F2CE00B25965 /* StyleTransformData.h in Headers */,
>+				55FA7FFF21110E6E005AEFE7 /* :SVGAnimatedPropertyType.h in Headers */,
> 				E4DEAA1817A93DC3000E0430 /* StyleTreeResolver.h in Headers */,
> 				E42E76DC1C7AF77600E3614D /* StyleUpdate.h in Headers */,
> 				E48137B91DB3B526005C59BF /* StyleValidity.h in Headers */,
>diff --git a/Source/WebCore/svg/properties/:SVGAnimatedPropertyType.h b/Source/WebCore/svg/properties/:SVGAnimatedPropertyType.h
>index 8b137891791..f8bad439e32 100644
>--- a/Source/WebCore/svg/properties/:SVGAnimatedPropertyType.h
>+++ b/Source/WebCore/svg/properties/:SVGAnimatedPropertyType.h
>@@ -1 +1,58 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc.  All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
> 
>+#pragma once
>+
>+namespace WebCore {
>+
>+enum AnimatedPropertyState {
>+    PropertyIsReadWrite,
>+    PropertyIsReadOnly
>+};
>+
>+enum AnimatedPropertyType {
>+    AnimatedPropertyTypeMin = 0,
>+    AnimatedAngle = AnimatedPropertyTypeMin,
>+    AnimatedBoolean,
>+    AnimatedColor,
>+    AnimatedEnumeration,
>+    AnimatedInteger,
>+    AnimatedIntegerOptionalInteger,
>+    AnimatedLength,
>+    AnimatedLengthList,
>+    AnimatedNumber,
>+    AnimatedNumberList,
>+    AnimatedNumberOptionalNumber,
>+    AnimatedPath,
>+    AnimatedPoints,
>+    AnimatedPreserveAspectRatio,
>+    AnimatedRect,
>+    AnimatedString,
>+    AnimatedTransformList,
>+    AnimatedPropertyTypeMax,
>+    AnimatedUnknown = AnimatedPropertyTypeMax
>+};
>+
>+}
>diff --git a/Source/WebCore/svg/properties/SVGPropertyInfo.h b/Source/WebCore/svg/properties/SVGPropertyInfo.h
>index e1d5292dbc4..9a8ee63a9d0 100644
>--- a/Source/WebCore/svg/properties/SVGPropertyInfo.h
>+++ b/Source/WebCore/svg/properties/SVGPropertyInfo.h
>@@ -26,34 +26,6 @@ namespace WebCore {
> class SVGAnimatedProperty;
> class SVGElement;
> 
>-enum AnimatedPropertyState {
>-    PropertyIsReadWrite,
>-    PropertyIsReadOnly
>-};
>-
>-enum AnimatedPropertyType {
>-    AnimatedPropertyTypeMin = 0,
>-    AnimatedAngle = AnimatedPropertyTypeMin,
>-    AnimatedBoolean,
>-    AnimatedColor,
>-    AnimatedEnumeration,
>-    AnimatedInteger,
>-    AnimatedIntegerOptionalInteger,
>-    AnimatedLength,
>-    AnimatedLengthList,
>-    AnimatedNumber,
>-    AnimatedNumberList,
>-    AnimatedNumberOptionalNumber,
>-    AnimatedPath,
>-    AnimatedPoints,
>-    AnimatedPreserveAspectRatio,
>-    AnimatedRect,
>-    AnimatedString,
>-    AnimatedTransformList,
>-    AnimatedPropertyTypeMax,
>-    AnimatedUnknown = AnimatedPropertyTypeMax
>-};
>-
> struct SVGPropertyInfo {
>     WTF_MAKE_FAST_ALLOCATED;
> public:

Actions: View | Formatted Diff | Diff

Attachments on bug 186751: 342916 | 342917 | 342985 | 343001 | 343114 | 343123 | 343124 | 343127 | 343129 | 343162 | 343167 | 343169 | 343171 | 343174 | 343213 | 343217 | 343327 | 343335 | 343338 | 343339 | 343343 | 343415 | 343979 | 343989 | 344002 | 344513 | 344516 | 344523 | 344534 | 344536 | 344988 | 344990 | 346097 | 346103 | 346124 | 346129 | 346177 | 346179 | 346180 | 346182 | 346185 | 346188 | 346190 | 346192 | 346193 | 346197 | 346199 | 346201 | 346202 | 346203 | 346204 | 346205 | 346206 | 346207 | 346211 | 346212 | 346217 | 346224 | 346230 | 346233 | 346241 | 346244 | 346245 | 346315 | 346316 | 346317 | 346318 | 346319 | 346320 | 346322 | 346323 | 346324 | 346325 | 346326 | 346327 | 346328 | 346329 | 346330 | 346331 | 346332 | 346333 | 346334 | 346335 | 346336 | 346337 | 346338 | 346339 | 346340 | 346341 | 346342 | 346343 | 346344 | 346345 | 346346 | 346347 | 346348 | 346349 | 346350 | 346518 | 346519 | 346520 | 346521 | 346522 | 346524 | 346525 | 346526 | 346527 | 346528 | 346529 | 346530 | 346531 | 346532 | 346533 | 346534 | 346535 | 346536 | 346537 | 346538 | 346539 | 346540 | 346541 | 346545 | 346546 | 346549 | 346551 | 346552 | 346601 | 346602 | 346611 | 346636 | 346642