Attachment 346206 Details for Bug 186751 – Add a registration method for SVGStringListValues

[patch] Add a registration method for SVGStringListValues

186751-21.patch (text/plain), 3.97 KB, created by Said Abou-Hallawa on 2018-07-31 14:36:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2018-07-31 14:36:50 PDT

Size: 3.97 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7861bb8ba55..f3d200fc1aa 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-07-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        [21] Remove the SVG elements' attributes macros
>+        https://bugs.webkit.org/show_bug.cgi?id=186751
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add registration methods for SVGStringListValues.
>+
>+        1. Define SVGStringListValuesAttribute and SVGStringListValuesAttributeAccessor
>+        2. Add template functions in SVGAttributeRegistry for registering
>+           attributes of type SVGStringListValuesAttribute.
>+
>+        An example of registering SVGStringListValuesAttribute:
>+            registry.registerAttribute<SVGNames::requiredFeaturesAttr, &SVGTests::m_requiredFeatures>();
>+
>+        * svg/SVGStringListValues.h:
>+        (WebCore::SVGPropertyTraits<SVGStringListValues>::toString):
>+        * svg/properties/SVGAttributeRegistry.h:
>+
> 2018-07-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         [20] Remove the SVG elements' attributes macros
>diff --git a/Source/WebCore/svg/SVGStringListValues.h b/Source/WebCore/svg/SVGStringListValues.h
>index 89651c7af04..6eca0417fa7 100644
>--- a/Source/WebCore/svg/SVGStringListValues.h
>+++ b/Source/WebCore/svg/SVGStringListValues.h
>@@ -1,6 +1,7 @@
> /*
>  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
>  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>  *
>  * This library is free software; you can redistribute it and/or
>  * modify it under the terms of the GNU Library General Public
>@@ -22,16 +23,24 @@
> 
> #include "QualifiedName.h"
> #include "SVGPropertyTraits.h"
>+#include "SVGAttributeAccessor.h"
>+
> #include <wtf/Vector.h>
> 
> namespace WebCore {
> 
> class SVGElement;
> class SVGStringList;
>+class SVGStringListValues;
> 
> template<typename T> 
> class SVGPropertyTearOff;
> 
>+using SVGStringListValuesAttribute = SVGPropertyAttribute<SVGStringListValues>;
>+
>+template<typename OwnerType>
>+using SVGStringListValuesAttributeAccessor = SVGPropertyAttributeAccessor<OwnerType, SVGStringListValuesAttribute>;
>+
> class SVGStringListValues final : public Vector<String> {
> public:
>     SVGStringListValues(const QualifiedName& attributeName)
>@@ -52,6 +61,8 @@ private:
> };
> 
> template<> struct SVGPropertyTraits<SVGStringListValues> {
>+    static String toString(const SVGStringListValues& list) { return list.valueAsString(); }
>+
>     using ListItemType = String;
>     using ListItemTearOff = SVGPropertyTearOff<String>;
>     using ListPropertyTearOff = SVGStringList;
>diff --git a/Source/WebCore/svg/properties/SVGAttributeRegistry.h b/Source/WebCore/svg/properties/SVGAttributeRegistry.h
>index b69ff518f74..9deff3b4210 100644
>--- a/Source/WebCore/svg/properties/SVGAttributeRegistry.h
>+++ b/Source/WebCore/svg/properties/SVGAttributeRegistry.h
>@@ -39,6 +39,7 @@
> #include "SVGAnimatedString.h"
> #include "SVGAnimatedTransformList.h"
> #include "SVGAttributeAccessor.h"
>+#include "SVGStringListValues.h"
> #include "SVGZoomAndPanType.h"
> #include <wtf/HashMap.h>
> 
>@@ -53,12 +54,20 @@ public:
>         return map;
>     }
> 
>+    // Non animatable attributes
>+    template<const LazyNeverDestroyed<const QualifiedName>& attributeName, SVGStringListValuesAttribute OwnerType::*attribute>
>+    void registerAttribute()
>+    {
>+        registerAttribute(SVGStringListValuesAttributeAccessor<OwnerType>::template singleton<attributeName, attribute>());
>+    }
>+
>     template<const LazyNeverDestroyed<const QualifiedName>& attributeName, SVGZoomAndPanTypeAttribute OwnerType::*attribute>
>     void registerAttribute()
>     {
>         registerAttribute(SVGZoomAndPanTypeAttributeAccessor<OwnerType>::template singleton<attributeName, attribute>());
>     }
> 
>+    // Animatable attributes
>     template<const LazyNeverDestroyed<const QualifiedName>& attributeName, SVGAnimatedBooleanAttribute OwnerType::*attribute>
>     void registerAttribute()
>     {

Actions: View | Formatted Diff | Diff

Attachments on bug 186751: 342916 | 342917 | 342985 | 343001 | 343114 | 343123 | 343124 | 343127 | 343129 | 343162 | 343167 | 343169 | 343171 | 343174 | 343213 | 343217 | 343327 | 343335 | 343338 | 343339 | 343343 | 343415 | 343979 | 343989 | 344002 | 344513 | 344516 | 344523 | 344534 | 344536 | 344988 | 344990 | 346097 | 346103 | 346124 | 346129 | 346177 | 346179 | 346180 | 346182 | 346185 | 346188 | 346190 | 346192 | 346193 | 346197 | 346199 | 346201 | 346202 | 346203 | 346204 | 346205 | 346206 | 346207 | 346211 | 346212 | 346217 | 346224 | 346230 | 346233 | 346241 | 346244 | 346245 | 346315 | 346316 | 346317 | 346318 | 346319 | 346320 | 346322 | 346323 | 346324 | 346325 | 346326 | 346327 | 346328 | 346329 | 346330 | 346331 | 346332 | 346333 | 346334 | 346335 | 346336 | 346337 | 346338 | 346339 | 346340 | 346341 | 346342 | 346343 | 346344 | 346345 | 346346 | 346347 | 346348 | 346349 | 346350 | 346518 | 346519 | 346520 | 346521 | 346522 | 346524 | 346525 | 346526 | 346527 | 346528 | 346529 | 346530 | 346531 | 346532 | 346533 | 346534 | 346535 | 346536 | 346537 | 346538 | 346539 | 346540 | 346541 | 346545 | 346546 | 346549 | 346551 | 346552 | 346601 | 346602 | 346611 | 346636 | 346642