Attachment 346183 Details for Bug 188202 – Patch

[patch] Patch

bug-188202-20180731114840.patch (text/plain), 1.85 KB, created by Myles C. Maxfield on 2018-07-31 11:48:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-07-31 11:48:40 PDT

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 234433
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a8fb1912198bfab0f4cf6dd072e03e181047cdfb..8486af29f13ee9e081bba79b295b11747f359656 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-31  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Cocoa] Addressing post-review comments on r234158
>+        https://bugs.webkit.org/show_bug.cgi?id=188202
>+
>+        Reviewed by Darin Adler.
>+
>+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
>+        (WebCore::FontCache::lastResortFallbackFont):
>+
> 2018-07-31  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         Clean up TransformationMatrix implementation
>diff --git a/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp b/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
>index 63014e25a151eecb76d6e34ce52dafe7a7af3208..c48102036cb78ba6c59d019101f96c23449e47e0 100644
>--- a/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
>+++ b/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
>@@ -1484,11 +1484,6 @@ Ref<Font> FontCache::lastResortFallbackFont(const FontDescription& fontDescripti
>     if (auto result = fontForFamily(fontDescription, AtomicString("Times", AtomicString::ConstructFromLiteral)))
>         return *result;
> 
>-    // The Times fallback will almost always work, but in the highly unusual case where
>-    // the user doesn't have it, we fall back on Lucida Grande.
>-    if (auto result = fontForFamily(fontDescription, AtomicString("Lucida Grande", AtomicString::ConstructFromLiteral), nullptr, nullptr, { }, false))
>-        return *result;
>-
>     // LastResort is guaranteed to be non-null.
> #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300)
>     auto fontDescriptor = adoptCF(CTFontDescriptorCreateLastResort());

Actions: View | Formatted Diff | Diff

Attachments on bug 188202: 346183