Attachment 346175 Details for Bug 188199 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

tooltip.patch (text/plain), 1.38 KB, created by Joseph Pecoraro on 2018-07-31 10:40:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-07-31 10:40:16 PDT

Size: 1.38 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 3a9a6bb6ea8..eefca0a9b0c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-07-31  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Include a full URL tooltip when hovering the name in the Network Tab
>+        https://bugs.webkit.org/show_bug.cgi?id=188199
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView.prototype._populateNameCell):
>+        Give a tooltip to the entire cell since the entire cell has interactivity.
>+
> 2018-07-26  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234281.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index cfb4460c242..0c9fb02dffd 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -441,6 +441,8 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
> 
>         let nameElement = cell.appendChild(document.createElement("span"));
>         nameElement.textContent = entry.name;
>+
>+        cell.title = entry.resource.url;
>     }
> 
>     _populateDomainCell(cell, entry)

Actions: View | Formatted Diff | Diff

Attachments on bug 188199: 346175 | 346176