WebKit Bugzilla
Attachment 346162 Details for
Bug 188160
: server_process.py should print returncode in debug log if the process crashed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188160-20180731222243.patch (text/plain), 1.48 KB, created by
Fujii Hironori
on 2018-07-31 06:22:44 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2018-07-31 06:22:44 PDT
Size:
1.48 KB
patch
obsolete
>Subversion Revision: 234422 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 47aeb92594d9d55d559637d022a05d251b85219f..e4ce23236904968a8b8449c6b04a9b32ee2165f5 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,13 @@ >+2018-07-31 Fujii Hironori <Hironori.Fujii@sony.com> >+ >+ server_process.py should print returncode in debug log if the process crashed >+ https://bugs.webkit.org/show_bug.cgi?id=188160 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/webkitpy/port/server_process.py: >+ (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message. >+ > 2018-07-31 Tomas Popela <tpopela@redhat.com> > > [WTF] String::formatWithArguments() is unused >diff --git a/Tools/Scripts/webkitpy/port/server_process.py b/Tools/Scripts/webkitpy/port/server_process.py >index 1a39242d918060aeccfe049fba59085bfed5cbc4..453d1ba02579bb5a3eedc8564b4772a9db0907a8 100644 >--- a/Tools/Scripts/webkitpy/port/server_process.py >+++ b/Tools/Scripts/webkitpy/port/server_process.py >@@ -323,7 +323,7 @@ class ServerProcess(object): > > def has_crashed(self): > if not self._crashed and self.poll(): >- _log.debug('This test marked as a crash because of failure to poll the server process.') >+ _log.debug('This test marked as a crash because of failure to poll the server process (return code was %s).' % self._proc.returncode) > self._crashed = True > self._handle_possible_interrupt() > return self._crashed
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188160
:
346056
| 346162