Attachment 346130 Details for Bug 188181 – Patch

[patch] Patch

bug-188181-20180730173525.patch (text/plain), 2.42 KB, created by Timothy Hatcher on 2018-07-30 17:35:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-07-30 17:35:25 PDT

Size: 2.42 KB

patch

obsolete

>Subversion Revision: 234371
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 19d1329363207988fed2e77c6c690d852948b2d5..14a23b758076c03ff82c812d21f13fa0d67cc75c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-30  Timothy Hatcher  <timothy@apple.com>
>+
>+        Don't call RenderTheme::platformColorsDidChange() during printing.
>+        https://bugs.webkit.org/show_bug.cgi?id=188181
>+        rdar://problem/42360070
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/agents/InspectorPageAgent.cpp:
>+        (WebCore::InspectorPageAgent::setEmulatedMedia): Call m_page.updateStyleAfterChangeInEnvironment()
>+        instead of going to styleStope() and remove call to RenderTheme::platformColorsDidChange().
>+        * page/FrameView.cpp:
>+        (WebCore::FrameView::adjustMediaTypeForPrinting): Remove call RenderTheme::platformColorsDidChange().
>+
> 2018-07-30  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed internal build fix after r234347.
>diff --git a/Source/WebCore/inspector/agents/InspectorPageAgent.cpp b/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
>index a0eb648ba7b033842ee4f57ed3241a15300c4cf1..507ffba657e38e44cb6493a5d0be4c889ec1a63b 100644
>--- a/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
>+++ b/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
>@@ -802,12 +802,10 @@ void InspectorPageAgent::setEmulatedMedia(ErrorString&, const String& media)
> 
>     m_emulatedMedia = media;
> 
>-    RenderTheme::singleton().platformColorsDidChange();
>+    m_page.updateStyleAfterChangeInEnvironment();
> 
>-    if (auto document = m_page.mainFrame().document()) {
>-        document->styleScope().didChangeStyleSheetEnvironment();
>+    if (auto* document = m_page.mainFrame().document())
>         document->updateLayout();
>-    }
> }
> 
> void InspectorPageAgent::applyEmulatedMedia(String& media)
>diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp
>index 5189acd96ca00e45d5e9c50f753d29c64c6bbed9..1ef032d6502585b968c80176b8aa4853035c7b30 100644
>--- a/Source/WebCore/page/FrameView.cpp
>+++ b/Source/WebCore/page/FrameView.cpp
>@@ -1388,8 +1388,6 @@ void FrameView::adjustMediaTypeForPrinting(bool printing)
>             setMediaType(m_mediaTypeWhenNotPrinting);
>         m_mediaTypeWhenNotPrinting = String();
>     }
>-
>-    RenderTheme::singleton().platformColorsDidChange();
> }
> 
> bool FrameView::useSlowRepaints(bool considerOverlap) const

Actions: View | Formatted Diff | Diff

Attachments on bug 188181: 346106 | 346117 | 346120 | 346125 | 346130