Attachment 346086 Details for Bug 187877 – Patch

[patch] Patch

bug-187877-20180730123806.patch (text/plain), 1.64 KB, created by Jer Noble on 2018-07-30 12:38:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-07-30 12:38:07 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 234062
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 485ee933895ffe044f8db6043818f7633148c286..a9318e972359a858b771052538b004dd9bac57aa 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-07-20  Jer Noble  <jer.noble@apple.com>
>+
>+        [iOS] PiP gets into a bad state if entering PiP fails
>+        https://bugs.webkit.org/show_bug.cgi?id=187877
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If the PiP machinery tells us we failed to enter fullscreen, we should tear down
>+        the window and the view.
>+
>+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
>+        (VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture):
>+
> 2018-07-19  Jer Noble  <jer.noble@apple.com>
> 
>         HLS resources with remote subresources will not taint canvasses.
>diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>index 5cc320e19dad39c009c73368a5871c86093e8b7d..03c1e7f280769f47254188df9bffe829342e2fd6 100644
>--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>@@ -1482,6 +1482,11 @@ void VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture()
>     if (m_currentMode.hasFullscreen())
>         return;
> 
>+    [m_window setHidden:YES];
>+    [[m_playerViewController view] setHidden:YES];
>+    if (m_hasVideoContentLayer && m_fullscreenChangeObserver)
>+        m_fullscreenChangeObserver->returnVideoContentLayer();
>+
>     if (m_fullscreenChangeObserver)
>         m_fullscreenChangeObserver->didEnterFullscreen();
>

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187877: 346086