Attachment 346076 Details for Bug 188128 – Patch

[patch] Patch

patch.txt (text/plain), 2.21 KB, created by Nikita Vasilyev on 2018-07-30 11:29:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-07-30 11:29:04 PDT

Size: 2.21 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index db62e91f69d..dd422c67b9e 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-07-30  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: Search sidebar panel text field has a white background
>+        https://bugs.webkit.org/show_bug.cgi?id=188128
>+        <rdar://problem/42678270>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make the search bar in Search tab match the style of the filter bar.
>+
>+        * UserInterface/Views/DarkMode.css:
>+        (@media (prefers-dark-interface)):
>+        (:matches(.search-bar, .filter-bar) > input[type="search"],):
>+        (:matches(.search-bar, .filter-bar) > input[type="search"]::placeholder):
>+        (:matches(.search-bar, .filter-bar) > input[type="search"]:focus):
>+        (.filter-bar > input[type="search"]): Deleted.
>+        (.filter-bar > input[type="search"]::placeholder): Deleted.
>+        (.filter-bar > input[type="search"]:focus): Deleted.
>+
> 2018-07-22  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Dark Mode: remove odd-looking top border
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>index dac6aec4bd4..ea625b52fe5 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>@@ -917,16 +917,17 @@
> 
> 
>     /* FilterBar.css */
>-    .filter-bar > input[type="search"] {
>+    :matches(.search-bar, .filter-bar) > input[type="search"],
>+    .search-bar > input[type="search"]:not(:placeholder-shown) {
>         border-color: var(--background-color-selected);
>         background-color: var(--background-color-alternate);
>     }
> 
>-    .filter-bar > input[type="search"]::placeholder {
>+    :matches(.search-bar, .filter-bar) > input[type="search"]::placeholder {
>         color: var(--text-color-secondary);
>     }
> 
>-    .filter-bar > input[type="search"]:focus {
>+    :matches(.search-bar, .filter-bar) > input[type="search"]:focus {
>         background-color: hsla(0, 0%, var(--foreground-lightness), 0.2);
>         color: var(--text-color-active);
>     }

Flags:

mattbaker: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188128: 345962 | 346074 | 346075 | 346076 | 346090