WebKit Bugzilla
Attachment 346074 Details for
Bug 188128
: Web Inspector: Dark Mode: Search sidebar panel text field has a white background
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 2.35 KB, created by
Nikita Vasilyev
on 2018-07-30 11:24:59 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Nikita Vasilyev
Created:
2018-07-30 11:24:59 PDT
Size:
2.35 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index db62e91f69d..dd422c67b9e 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,22 @@ >+2018-07-30 Nikita Vasilyev <nvasilyev@apple.com> >+ >+ Web Inspector: Dark Mode: Search sidebar panel text field has a white background >+ https://bugs.webkit.org/show_bug.cgi?id=188128 >+ <rdar://problem/42678270> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Make the search bar in Search tab match the style of the filter bar. >+ >+ * UserInterface/Views/DarkMode.css: >+ (@media (prefers-dark-interface)): >+ (:matches(.search-bar, .filter-bar) > input[type="search"],): >+ (:matches(.search-bar, .filter-bar) > input[type="search"]::placeholder): >+ (:matches(.search-bar, .filter-bar) > input[type="search"]:focus): >+ (.filter-bar > input[type="search"]): Deleted. >+ (.filter-bar > input[type="search"]::placeholder): Deleted. >+ (.filter-bar > input[type="search"]:focus): Deleted. >+ > 2018-07-22 Nikita Vasilyev <nvasilyev@apple.com> > > Web Inspector: Dark Mode: remove odd-looking top border >diff --git a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css >index dac6aec4bd4..97fb2536e24 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css >+++ b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css >@@ -917,18 +917,19 @@ > > > /* FilterBar.css */ >- .filter-bar > input[type="search"] { >+ :matches(.search-bar, .filter-bar) > input[type="search"], >+ .search-bar > input[type="search"]:not(:placeholder-shown) { > border-color: var(--background-color-selected); >- background-color: var(--background-color-alternate); >+ background-color: var(--background-color-alternate) > } > >- .filter-bar > input[type="search"]::placeholder { >- color: var(--text-color-secondary); >+ :matches(.search-bar, .filter-bar) > input[type="search"]::placeholder { >+ color: var(--text-color-secondary) > } > >- .filter-bar > input[type="search"]:focus { >+ :matches(.search-bar, .filter-bar) > input[type="search"]:focus { > background-color: hsla(0, 0%, var(--foreground-lightness), 0.2); >- color: var(--text-color-active); >+ color: var(--text-color-active) > } > >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188128
:
345962
|
346074
|
346075
|
346076
|
346090