WebKit Bugzilla
Attachment 346059 Details for
Bug 188145
: Hardcoded LFENCE instruction
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188145-20180730174244.patch (text/plain), 1.13 KB, created by
karogyoker2+webkit
on 2018-07-30 08:42:44 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
karogyoker2+webkit
Created:
2018-07-30 08:42:44 PDT
Size:
1.13 KB
patch
obsolete
>Index: Source/WTF/ChangeLog >=================================================================== >--- Source/WTF/ChangeLog (revision 234364) >+++ Source/WTF/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2018-07-30 Karo Gyoker <karogyoker2@gmail.com> >+ >+ Only use LFENCE if CPU supports SSE2, otherwise use the slower CPUID. >+ https://bugs.webkit.org/show_bug.cgi?id=188145 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * wtf/Atomics.h: >+ (WTF::speculationFence): >+ > 2018-07-28 Mark Lam <mark.lam@apple.com> > > Gardening: build fix for internal builds. >Index: Source/WTF/wtf/Atomics.h >=================================================================== >--- Source/WTF/wtf/Atomics.h (revision 234364) >+++ Source/WTF/wtf/Atomics.h (working copy) >@@ -322,7 +322,11 @@ inline void storeStoreFence() { compiler > inline void memoryBarrierAfterLock() { compilerFence(); } > inline void memoryBarrierBeforeUnlock() { compilerFence(); } > inline void crossModifyingCodeFence() { x86_cpuid(); } >+#if CPU(X86_SSE2) > inline void speculationFence() { x86_lfence(); } >+#else >+inline void speculationFence() { x86_cpuid(); } >+#endif > > #else >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188145
:
346020
|
346021
|
346034
|
346059
|
346112
|
346589
|
346591
|
346598