Attachment 346056 Details for Bug 188160 – Patch

[patch] Patch

bug-188160-20180730184142.patch (text/plain), 1.52 KB, created by Fujii Hironori on 2018-07-30 02:41:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-07-30 02:41:43 PDT

Size: 1.52 KB

patch

obsolete

>Subversion Revision: 234360
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 86d449021bfbb1d4dce25ddcf6b696a3ffa58303..f591ed6205e26cc29412979fd928d7dac574388f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        server_process.py should print returncode in debug log if the process crashed
>+        https://bugs.webkit.org/show_bug.cgi?id=188160
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/port/server_process.py:
>+        (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
>+
> 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed, fix typo in test expectations and mark another test as timing out
>diff --git a/Tools/Scripts/webkitpy/port/server_process.py b/Tools/Scripts/webkitpy/port/server_process.py
>index 1a39242d918060aeccfe049fba59085bfed5cbc4..4188754782e062cb79431e906974c0e9918d8b5c 100644
>--- a/Tools/Scripts/webkitpy/port/server_process.py
>+++ b/Tools/Scripts/webkitpy/port/server_process.py
>@@ -323,7 +323,7 @@ class ServerProcess(object):
> 
>     def has_crashed(self):
>         if not self._crashed and self.poll():
>-            _log.debug('This test marked as a crash because of failure to poll the server process.')
>+            _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode)
>             self._crashed = True
>             self._handle_possible_interrupt()
>         return self._crashed

Flags:

Hironori.Fujii: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 188160: 346056 | 346162