Attachment 346021 Details for Bug 188145 – Patch

[patch] Patch

bug-188145-20180729105359.patch (text/plain), 1019 bytes, created by karogyoker2+webkit on 2018-07-29 01:54:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: karogyoker2+webkit

Created: 2018-07-29 01:54:01 PDT

Size: 1019 bytes

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 234345)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-07-29  Karo Gyoker  <karogyoker2@gmail.com>
>+
>+        Only use LFENCE if CPU supports SSE2. Applying this fix was required to be
>+        able to run WebKit again on Athlon XP.
>+        https://bugs.webkit.org/show_bug.cgi?id=188145
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Atomics.h:
>+        (WTF::x86_lfence):
>+
> 2018-07-28  Mark Lam  <mark.lam@apple.com>
> 
>         Gardening: build fix for internal builds.
>Index: Source/WTF/wtf/Atomics.h
>===================================================================
>--- Source/WTF/wtf/Atomics.h	(revision 234345)
>+++ Source/WTF/wtf/Atomics.h	(working copy)
>@@ -282,7 +282,7 @@ inline void speculationFence() { arm_isb
> 
> inline void x86_lfence()
> {
>-#if !OS(WINDOWS)
>+#if !OS(WINDOWS) && CPU(X86_SSE2)
>     asm volatile("lfence" ::: "memory");
> #endif
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 188145: 346020 | 346021 | 346034 | 346059 | 346112 | 346589 | 346591 | 346598