WebKit Bugzilla
Attachment 345993 Details for
Bug 188138
: Reset CompositingPolicyOverride between tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188138-20180728105320.patch (text/plain), 1.48 KB, created by
Simon Fraser (smfr)
on 2018-07-28 10:53:21 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Simon Fraser (smfr)
Created:
2018-07-28 10:53:21 PDT
Size:
1.48 KB
patch
obsolete
>Subversion Revision: 234343 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 102c257fa1d4be9ba2b1d1ad9ec61e0ee758dc72..db5944ab0facb30bd4a128a52c48840d673e0c15 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-07-28 Simon Fraser <simon.fraser@apple.com> >+ >+ Reset CompositingPolicyOverride between tests >+ https://bugs.webkit.org/show_bug.cgi?id=188138 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ WK1 tests were failing after r234330 because the compositing policy override optional >+ was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having >+ Internals::resetToConsistentState clear this state. >+ >+ * testing/Internals.cpp: >+ (WebCore::Internals::resetToConsistentState): >+ > 2018-07-24 Simon Fraser <simon.fraser@apple.com> > > Animation stops with object-fit:contain on an animated 2d canvas >diff --git a/Source/WebCore/testing/Internals.cpp b/Source/WebCore/testing/Internals.cpp >index e706b5bccda9415e24006c9b9de91e9e1585f01f..03ae9fc83ea0a88692970cc47fb1f3168d585a93 100644 >--- a/Source/WebCore/testing/Internals.cpp >+++ b/Source/WebCore/testing/Internals.cpp >@@ -438,6 +438,8 @@ void Internals::resetToConsistentState(Page& page) > > page.mainFrame().setTextZoomFactor(1.0f); > >+ page.setCompositingPolicyOverride(std::nullopt); >+ > FrameView* mainFrameView = page.mainFrame().view(); > if (mainFrameView) { > mainFrameView->setHeaderHeight(0);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188138
: 345993