Attachment 345966 Details for Bug 188127 – Patch

[patch] Patch

bug-188127-20180727161120.patch (text/plain), 1.91 KB, created by Eric Carlson on 2018-07-27 16:11:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-07-27 16:11:21 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 234336
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index abcadb01807e0e81f1f24bdc822ffab9c2e51118..0ce142d5aa4754554daac0dffbb66bb08f7cd4c8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-07-27  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [iOS] Don't deactivate audio session
>+        https://bugs.webkit.org/show_bug.cgi?id=188127
>+        <rdar://problem/42544143>
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        r233435 includes a change that deactivates the shared audio session when there are no more
>+        active media sessions. This is a good in WK2 because it allows other applications to resume
>+        playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host
>+        app may also be playing audio.
>+
>+        * platform/audio/PlatformMediaSessionManager.cpp:
>+        (WebCore::PlatformMediaSessionManager::removeSession): Don't deactivate the audio session.
>+
> 2018-07-27  Chris Dumez  <cdumez@apple.com>
> 
>         Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable()
>diff --git a/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp b/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>index ca72d42a974240db1e9f0190a0439b5a791a20c0..f8c531a7bc24c6e42b6677d73af164e03e1cfd06 100644
>--- a/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>+++ b/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
>@@ -162,9 +162,6 @@ void PlatformMediaSessionManager::removeSession(PlatformMediaSession& session)
>     if (m_sessions.isEmpty() || std::all_of(m_sessions.begin(), m_sessions.end(), std::logical_not<void>())) {
>         m_remoteCommandListener = nullptr;
>         m_audioHardwareListener = nullptr;
>-#if USE(AUDIO_SESSION)
>-        AudioSession::sharedSession().tryToSetActive(false);
>-#endif
>     }
> 
>     scheduleUpdateSessionState();

Actions: View | Formatted Diff | Diff

Attachments on bug 188127: 345966