Attachment 345956 Details for Bug 188122 – Patch

[patch] Patch

bug-188122-20180727144201.patch (text/plain), 6.50 KB, created by zalan on 2018-07-27 14:42:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-07-27 14:42:02 PDT

Size: 6.50 KB

patch

obsolete

>Subversion Revision: 234325
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 81736d8728bdeed2516020bde36855ba706e6de0..67d3e20863d840b41707b7caa3b6de556ad85330 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-07-27  Zalan Bujtas  <zalan@apple.com>
>+
>+        [WK1] ASSERTION FAILED: renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) in WebCore::RenderLayer::updateLayerPositionsAfterScroll
>+        https://bugs.webkit.org/show_bug.cgi?id=188122
>+        <rdar://problem/42584790>
>+
>+        Reviewed by Simon Fraser.
>+
>+        When ScrollView's m_paintsEntireContents flag flips due to layer backing changes, the repaint area transitions from
>+        visual to layout overflow. When this happens the cached repaint rects become invalid and they need to be recomputed.
>+        Currently there's no mechanism to trigger repaint cache invalidation from ScrollView.
>+        Skip assertion for now on WK1 (see webkit.org/b/188121)
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
>+
> 2018-07-27  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WIN] Crash when trying to access store pages
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index 6cf1f9cd483e514f5fd1f81d64689517add7c099..d6cfd6a3a5d931714c830ed5f252c98b1bc6574c 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -881,7 +881,9 @@ void RenderLayer::updateLayerPositionsAfterScroll(RenderGeometryMap* geometryMap
>             clearRepaintRects();
>         else // FIXME: We could track the repaint container as we walk down the tree.
>             computeRepaintRects(renderer().containerForRepaint(), geometryMap);
>-    } else {
>+    } else if (!renderer().view().frameView().platformWidget()) {
>+        // When ScrollView's m_paintsEntireContents flag flips due to layer backing changes, the repaint area transitions from
>+        // visual to layout overflow. When this happens the cached repaint rects become invalid and they need to be recomputed (see webkit.org/b/188121).
>         // Check that our cached rects are correct.
>         ASSERT(!renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()));
>         ASSERT(!renderer().hasRepaintLayoutRects() || renderer().repaintLayoutRects().m_outlineBox == renderer().outlineBoundsForRepaint(renderer().containerForRepaint()));
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 7bb34e396766ad0e8b1afd6e2323114faa9de129..e4b6861d1de4ced7ecce93c4307183ba1cd1776c 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-27  Zalan Bujtas  <zalan@apple.com>
>+
>+        [WK1] ASSERTION FAILED: renderer().repaintLayoutRects().m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) in WebCore::RenderLayer::updateLayerPositionsAfterScroll
>+        https://bugs.webkit.org/show_bug.cgi?id=188122
>+        <rdar://problem/42584790>
>+
>+        Reviewed by Simon Fraser.
>+
>+        * platform/mac-wk1/TestExpectations:
>+
> 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed GTK test gardening
>diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
>index 584b2d529eea44a45df557ee53eb4c7404c56f68..84bb4cf34ce97afaa3ba99ea8122789018ebf0d6 100644
>--- a/LayoutTests/platform/mac-wk1/TestExpectations
>+++ b/LayoutTests/platform/mac-wk1/TestExpectations
>@@ -586,43 +586,6 @@ webkit.org/b/187557 [ Debug ] media/media-fragments/TC0091.html [ Pass Failure ]
> 
> webkit.org/b/187711 [ Debug ] svg/custom/linking-uri-01-b.svg [ Pass Failure ]
> 
>-# <rdar://problem/42584790>
>-[ Mojave+ Debug ] fast/css/sticky/inflow-sticky.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/inline-sticky-abspos-child.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/inline-sticky.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/replaced-sticky.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-as-positioning-container.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-both-sides.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-left-percentage.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-left.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-margins.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-overflowing.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-side-margins.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-table-row-top.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-table-thead-top.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-top-margins.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-top.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-writing-mode-horizontal-bt.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-writing-mode-vertical-lr.html [ Skip ]
>-[ Mojave+ Debug ] fast/css/sticky/sticky-writing-mode-vertical-rl.html [ Skip ]
>-[ Mojave+ Debug ] fast/events/document-elementFromPoint.html [ Skip ]
>-[ Mojave+ Debug ] fast/events/offsetX-offsetY.html [ Skip ]
>-[ Mojave+ Debug ] fast/hidpi/hidpi-long-page-with-inset-element.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/absolute-position-changed.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/fixed-scale.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/fixed-table-cell.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/fixed-table-overflow-zindex.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/fixed-table-overflow.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/fixed.html [ Skip ]
>-[ Mojave+ Debug ] fast/repaint/scroll-fixed-layer-with-reflection.html [ Skip ]
>-[ Mojave+ Debug ] fast/scrolling/rtl-scrollbars-sticky-document-2.html [ Skip ]
>-[ Mojave+ Debug ] fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html [ Skip ]
>-[ Mojave+ Debug ] fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html [ Skip ]
>-[ Mojave+ Debug ] fast/visual-viewport/zoomed-scroll-to-anchor-in-position-fixed.html [ Skip ]
>-[ Mojave+ Debug ] fast/zooming/client-rect-in-fixed-zoomed.html [ Skip ]
>-[ Mojave+ Debug ] transforms/2d/perspective-not-fixed-container.html [ Skip ]
>-[ Mojave+ Debug ] transforms/2d/preserve3d-not-fixed-container.html [ Skip ]
>-
> # <rdar://problem/42625657>
> [ Mojave+ ] fast/images/animated-gif-paint-after-animation.html [ Skip ]
> [ Mojave+ ] fast/images/async-image-background-image-repeated.html [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 188122: 345949 | 345956