Attachment 345931 Details for Bug 188099 – Test patch

[patch] Test patch

bug-188099-20180727112726.patch (text/plain), 1.78 KB, created by Myles C. Maxfield on 2018-07-27 11:27:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-07-27 11:27:27 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 234318
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 81736d8728bdeed2516020bde36855ba706e6de0..e33afbc84b0e745f64c371d3c663b5fe59a009ac 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-07-27  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [WIN] Fix text with initial advance tests
>+        https://bugs.webkit.org/show_bug.cgi?id=188099
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * platform/graphics/FontCascade.cpp:
>+        (WebCore::FontCascade::drawGlyphBuffer const):
>+
> 2018-07-27  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WIN] Crash when trying to access store pages
>diff --git a/Source/WebCore/platform/graphics/FontCascade.cpp b/Source/WebCore/platform/graphics/FontCascade.cpp
>index 932789461acf36a12dd158a8306bdf945505881a..c7e865c01e3948f3c5c963cf5fef39b709bbc585 100644
>--- a/Source/WebCore/platform/graphics/FontCascade.cpp
>+++ b/Source/WebCore/platform/graphics/FontCascade.cpp
>@@ -1433,7 +1433,12 @@ void FontCascade::drawGlyphBuffer(GraphicsContext& context, const GlyphBuffer& g
>     // Draw each contiguous run of glyphs that use the same font data.
>     const Font* fontData = glyphBuffer.fontAt(0);
>     // FIXME: Why do we subtract the initial advance's height but not its width???
>-    FloatPoint startPoint(point.x(), point.y() - glyphBuffer.initialAdvance().height());
>+#if PLATFORM(WIN)
>+    float initialYPosition = point.y();
>+#else
>+    float initialYPosition = point.y() - glyphBuffer.initialAdvance().height();
>+#endif
>+    FloatPoint startPoint(point.x(), initialYPosition);
>     float nextX = startPoint.x() + glyphBuffer.advanceAt(0).width();
>     float nextY = startPoint.y() + glyphBuffer.advanceAt(0).height();
>     unsigned lastFrom = 0;

Actions: View | Formatted Diff | Diff

Attachments on bug 188099: 345931 | 345961 | 345983 | 345988 | 345995 | 346007 | 346027 | 346184