Attachment 345899 Details for Bug 188069 – PATCH

[patch] PATCH

188069.diff (text/plain), 2.81 KB, created by Basuke Suzuki on 2018-07-26 20:43:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-07-26 20:43:07 PDT

Size: 2.81 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ee62ad93de8..b98fb201d5e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-26  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Set correct source info to ResourceResponse.
>+        https://bugs.webkit.org/show_bug.cgi?id=188069
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/wincairo/TestExpectations:
>+          - http/tests/cache/disk-cache/disk-cache-302-status-code.html: Pass
>+
> 2018-07-26  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234281.
>diff --git a/LayoutTests/platform/wincairo/TestExpectations b/LayoutTests/platform/wincairo/TestExpectations
>index 767cad8c979..e47329bfff0 100644
>--- a/LayoutTests/platform/wincairo/TestExpectations
>+++ b/LayoutTests/platform/wincairo/TestExpectations
>@@ -863,7 +863,7 @@ http/tests/websocket/tests/hybi/contentextensions/block-cookies.php [ Timeout ]
> http/tests/xmlhttprequest/simple-sync.html [ Crash ]
> 
> # DiskCache
>-http/tests/cache/disk-cache/disk-cache-302-status-code.html [ Failure ]
>+http/tests/cache/disk-cache/disk-cache-302-status-code.html [ Pass ]
> 
> #///////////////////////////////////////////////////////////////////////////////
> # Issue categories below are shared with other platforms (primarily AppleWin)
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 76b20100b02..aba26083424 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-07-26  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Set correct source info to ResourceResponse.
>+        https://bugs.webkit.org/show_bug.cgi?id=188069
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        ResourceResponseBase::Source::Network must be set by each ports. Curl port
>+        didn't set this.
>+
>+        Test: http/tests/cache/disk-cache/disk-cache-302-status-code.html
>+
>+        * platform/network/curl/ResourceResponseCurl.cpp:
>+        (WebCore::ResourceResponse::ResourceResponse):
>+
> 2018-07-26  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234281.
>diff --git a/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp b/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp
>index 02f30f629e9..f35705c53e7 100644
>--- a/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp
>+++ b/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp
>@@ -103,6 +103,7 @@ ResourceResponse::ResourceResponse(const CurlResponse& response)
>     }
>     setMimeType(extractMIMETypeFromMediaType(httpHeaderField(HTTPHeaderName::ContentType)).convertToASCIILowercase());
>     setTextEncodingName(extractCharsetFromMediaType(httpHeaderField(HTTPHeaderName::ContentType)));
>+    setSource(ResourceResponse::Source::Network);
> }
> 
> void ResourceResponse::appendHTTPHeaderField(const String& header)

Flags:

Hironori.Fujii: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 188069: 345899 | 345911 | 345916