WebKit Bugzilla
Attachment 345864 Details for
Bug 188075
: REGRESSION(r234181): These are not needed right now (Requested by thorton on #webkit).
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
ROLLOUT of r234181
bug-188075-20180726165611.patch (text/plain), 12.47 KB, created by
WebKit Commit Bot
on 2018-07-26 13:56:12 PDT
(
hide
)
Description:
ROLLOUT of r234181
Filename:
MIME Type:
Creator:
WebKit Commit Bot
Created:
2018-07-26 13:56:12 PDT
Size:
12.47 KB
patch
obsolete
>Subversion Revision: 234270 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 904e3dfc52e5a9b5a8067eae2db3e82fe20cf69e..4ec995f2d08a18afcc79c5eb1aed2e194746ed7c 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-26 Mark Lam <mark.lam@apple.com> > > arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array. >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index 785244ce1e8c996ba3d66a6aa019bff46d402b0c..5a2a74c6fb32a4ab97a05c6b475d87d29f1abad1 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-04 Darin Adler <darin@apple.com> > > Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 1bca51d373b0bfaf61896783a6de6d76650dbd57..1f660a2f37715b4841acfe944c728c96f5fb5f9c 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-26 Timothy Hatcher <timothy@apple.com> > > Use the Page's appearance when converting pasteboard attributed strings. >diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog >index 5fd6e9308ebde9fd5e4f0d7b4347ce45b886a8c4..be2cc616c19837264cdfc396f27e2e72de333735 100644 >--- a/Source/WebCore/PAL/ChangeLog >+++ b/Source/WebCore/PAL/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-24 Tim Horton <timothy_horton@apple.com> > > Enable Web Content Filtering on watchOS >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 60d3797e3c6c19243b0a23625adb602037bf6e89..7dac948a8f437fe1db4227a418aa21780eccc8a1 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-26 Chris Dumez <cdumez@apple.com> > > ERROR: Unhandled web process message 'WebPage:SetUseDarkAppearance' when browsing in dark mode >diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog >index ba5f1e3dd2b78b61991186901a374ebbcc307020..85a8862af45ad740dc7d0b045a956b289b9167ea 100644 >--- a/Source/WebKitLegacy/mac/ChangeLog >+++ b/Source/WebKitLegacy/mac/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-26 Timothy Hatcher <timothy@apple.com> > > Use the Page's appearance when converting pasteboard attributed strings. >diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING; >diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h >index 8397fab5b43d89e358ceb9898fba9ede31af605f..27ff5f673d92e7173d1dd17f617f34e5d8170ce1 100644 >--- a/Source/WTF/wtf/Platform.h >+++ b/Source/WTF/wtf/Platform.h >@@ -1044,9 +1044,6 @@ > > #if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !PLATFORM(IOSMAC) > #define ENABLE_DATA_DETECTION 1 >-#endif >- >-#if !PLATFORM(APPLETV) && !PLATFORM(IOSMAC) > #define HAVE_PARENTAL_CONTROLS 1 > #endif > >diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING; >diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING; >diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING; >diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING; >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index ab398e36d03c0c1d9ad29bd8d19cc706ad778674..f092bc9070779a56977be9dac912914620a73aea 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,21 @@ >+2018-07-26 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r234181 and r234189. >+ https://bugs.webkit.org/show_bug.cgi?id=188075 >+ >+ These are not needed right now (Requested by thorton on >+ #webkit). >+ >+ Reverted changesets: >+ >+ "Enable Web Content Filtering on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187979 >+ https://trac.webkit.org/changeset/234181 >+ >+ "HAVE(PARENTAL_CONTROLS) should be true on watchOS" >+ https://bugs.webkit.org/show_bug.cgi?id=187985 >+ https://trac.webkit.org/changeset/234189 >+ > 2018-07-04 Darin Adler <darin@apple.com> > > Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly >diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >index b65dbefe6569807b03a3ee48eb146fb33a596016..08099785c1842395361d55b0ea1a9b310dbd95c4 100644 >--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >@@ -62,8 +62,6 @@ ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING; > ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; > > ENABLE_CONTENT_FILTERING = $(ENABLE_CONTENT_FILTERING_$(WK_PLATFORM_NAME)); >-ENABLE_CONTENT_FILTERING_watchos = ENABLE_CONTENT_FILTERING; >-ENABLE_CONTENT_FILTERING_watchsimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphoneos = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_iphonesimulator = ENABLE_CONTENT_FILTERING; > ENABLE_CONTENT_FILTERING_macosx = ENABLE_CONTENT_FILTERING;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188075
:
345864
|
346009